Diff shows same properties being updated and deleted diff: -tags,tagsAll~tags,tagsAll

[lukehoban]

Deploy this with pulumi up:

import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";
import * as awsx from "@pulumi/awsx";

// Create an AWS resource (S3 Bucket)
const bucket = new aws.s3.BucketV2("my-bucket");

// Export the name of the bucket
export const bucketName = bucket.id;

Then modify the bucket in AWS Console to add a tag foo: bar.

Then run pulumi refresh and accept the results.

Then run pulumi up.

The result is this:

Previewing update (dev)

View in Browser (Ctrl+O): https://app.pulumi.com/luke-pulumi-corp/awsbucketrefresh2/dev/previews/34b6cfe4-72cd-4ada-89b6-34d391f79918

     Type                 Name                   Plan       Info
     pulumi:pulumi:Stack  awsbucketrefresh2-dev             
 ~   └─ aws:s3:BucketV2   my-bucket              update     [diff: -tags,tagsAll~tags,tagsAll]

Resources:
    ~ 1 to update
    1 unchanged

Note that tags and tagsAll show as both updated and deleted. This is misleading/incorrect.

The actual detailed diff that is returned from the AWS provider for this case is:

map[tags:{update false} tags.foo:{delete false} tagsAll:{update false} tagsAll.foo:{delete false}] 

Notice that there are actually diffs at different levels - tags is being updated, and tags.foo is being deleted. Even that doesn't seem necessarily correct? But regardless, rendering it as we do currently is even more wrong/misleading. We should fix at one/both of the CLI diff display and/or the detailed diff constructed by AWS / Terraform Bridge (with clear guidance on what is "legal" to produce in a diff such that whatever is produced will be displayed cleanly and correctly by the diff rendering logic).

[lukehoban]

Also arguably even more confusing display in the diff display:

  pulumi:pulumi:Stack: (same)
    [urn=urn:pulumi:dev::awsbucketrefresh2::pulumi:pulumi:Stack::awsbucketrefresh2-dev]
    ~ aws:s3/bucketV2:BucketV2: (update)
        [id=my-bucket-d9057d9]
        [urn=urn:pulumi:dev::awsbucketrefresh2::aws:s3/bucketV2:BucketV2::my-bucket]
        [provider=urn:pulumi:dev::awsbucketrefresh2::pulumi:providers:aws::default_6_33_1::7b86a3ea-729d-4614-aa0d-88713db03c1e]
      - tags   : {
          - foo: "bar"
        }
      - tags   : {
          - foo: "bar"
        }
      - tagsAll: {
          - foo: "bar"
        }
      - tagsAll: {
          - foo: "bar"
        }