Fix Jest runner timeout accounting races #11148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes oven-sh#11147 Jest runner would report incorrect timeouts, due to races in the timer accounting code. This commit arms and disarms timers before and after every test to ensure correct timeouts without false-positives.
|
Thank you for the PR, these changes look like they'll reduce some of the flakiness around timeouts |
gvilums
approved these changes
May 21, 2024
|
❌ @stefreak, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
🐧🖥 1 failing tests Linux x64
🪟💻 6 failing tests Windows x64 baseline
🪟💻 7 failing tests Windows x64
|
|
@stefreak Some of the new timeout tests seem to fail on windows. This is most likely because timers on windows are less accurate. I suggest increasing the tolerances in the tests and seeing if that fixes it. |
|
@gvilums thank you for the feedback! I'll have a look at that |
|
I'm trying to figure out which of these test failures are related to my change, and which are flakes. Could you approve the workflows again @gvilums? Thank you ❤️ |
|
I finally managed to get a working windows dev environment, but actually this has been fixed in the mean time by #11419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11147
Jest runner would report incorrect timeouts, due to races in the timer
accounting code.
This commit arms and disarms timers before and after every test to
ensure correct timeouts without false-positives.
How did you verify your code works?
I ran the test suite in #11147 manually and added to the automated test suite.
bun-debug test test-file-name.test)