Display a warning when closing a Pull Request tab without submitting review #46835
Unanswered
olttwa
asked this question in
Pull Requests
Replies: 1 comment 4 replies
-
Thank you for raising this as a need; I agree this is problematic for our team. I do however object: I'm against number 3, in that most people ignore most GitHub notifications today; adding another won't help anything. I'm also against number 2, because I strongly think comments need to be visible immediately. Changing visibility based on time passing is more confusing. Your number 1 is good but doesn't go far enough. We just need a mode where comments are immediately visible and are never "Pending". |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
There are 2 ways of leaving comments on a pull request:
Add single comment
orStart a review
.With the latter approach, I have seen multiple users forgetting to hit
Submit review
after having completed the review.As a result of this, comments stay in a non-submitted state and both the author and the reviewer are unaware of this.
I propose 3 ways this UX can be improved:
Beta Was this translation helpful? Give feedback.
All reactions