Feature request: Require approval from specific assigned reviewers (Required + Optional reviewers)

[WoodyWoodsta]

There seems to be no way to get something like this to work with the protection rules and CODEOWNERS file as it stands, at least that I know about.

The Problem

At face value, the problem is enabling auto-merge on a PR which has multiple reviewers (and a branch protection rule to require at least x approvals) will merge automatically after the first x approval(s) which may not be as intended.

Generally speaking, the problem is that there is no way for the PR author to specify specific required reviewers for their PR. In these cases, a simple "number of required reviewers" branch protection rule doesn't help.

Has this been approached before?

Proposed Solution

Azure Repos has the concept of required and optional reviewers, and a rule to require all required reviewers to approve before merge. This seems like a reasonable solution which covers most, if not all, use cases.

[stefangimmillaro]

glad to find someone else ready requested this feature

I would really like this too. I would like to specify automerge conditions on a specific pull request:

• Approval from specific reviews
• automerge only within a certain time of day window

lower priority for me personally

• number of approvals
• automerge only after another specific pr merges

[mbs-c]

We would love this feature, for slightly different reasons. Our ideal development workflow is as follows:

• Develop code change
• Create PR
• Assign reviewers (optional, depending on the type of change)
• Write your squash commit message and enable automerge
• Move on to the next task

GitHub currently doesn't allow us to follow this workflow, since you cannot assign specific people as required reviewers to specific PRs. Instead, you have to watch your emails and wait for the approval before you can write the squash commit message and click the merge button, which causes unnecessary context switches. I want to be able to request mandatory reviews from specific reviewers in a PR, without branch protection rules requiring x reviews for every PR.