Multiple Commit Selection doesnt support scroll

[Madalosso]

When reviewing a PR, on the Files Changed page, there's a menu that allows the reviewer to select the changes for

• All Changes
• Changes since your last review
• And we can select a specific commit or a range of commits.

The problem starts when I'm trying to select a range of commits, but I need to scroll the list of commits down to pick a specific one.
I can scroll down the list of commits while holding shift (which is the key that enables the multi-selection on commits), and if I release shift to try to press it again after scrolling, the feature won't work.

I don't know if I should list this as a discussion or a bug, but either way, this feature needs to support scrolling.
Tested on Chrome Version 98.0.4758.102 (Official Build) (64-bit)

[charlievrettos]

This seems to be happening to me even when I don't scroll. Selecting 6 of 15 commits, without scrolling, for example results in only 1 or 2 commits selected.

Tested on macOS Monterey 12.0.1

• Chrome Version 99.0.4844.51 (Official Build) (arm64)
• Safari Version 15.1 (17612.2.9.1.20)

[enricobattocchi]

The same is happening on Firefox 99.0 on Linux.

[bheston]

I'm experiencing the same as mentioned above.

Additionally, the interaction model is complex and should be reevaluated from an accessibility perspective. I can't figure out how to activate the feature with a keyboard and attempting to use it with a mouse is proving difficult or impossible.

Further, I really just want "Show changes since your last review", but that results in the dreaded "We went looking everywhere" message. I suspect that feature doesn't work on rebased branches as I frequently run into that with links from email notifications and my team rebases as a general rule.

[sezanzeb]

I went around this problem by inserting commit hashes into the url.

Making the list scroll down when moving the mouse to the bottom of the dropdown would also be cool while holding shift.

Or support selecting multiple commits by holding down shift and using arrow keys.

[Madalosso]

That's a nice alternative to get the functionality working. thanks for sharing.

[richfromm]

Thank you! Somewhat annoying, but great to have a workaround.

[jlevitt]

Also broken for me on Windows 11/Chrome.

[akgerber]

This remains broken for me, with or without scrolling.

[richfromm]

I've always found the multi-commit (but less than "all commits") selection within a PR to be hard to use, but indeed now I am finding it completely impossible if the range of commits requires scrolling.

macOS Sonoma 14.4.1, Chrome Version 124.0.6367.93 (Official Build) (arm64)

[tvsaru]

Came looking for a solution to this problem, but found this unresolved ticket.
On Sonoma 14.4.1 and Firefox 125.0.2.