Allow author to approve own PR if someone else has committed #120835
Unanswered
quilicicf
asked this question in
Pull Requests
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Select Topic Area
Product Feedback
Body
A common use case I regularly stumble upon is a PR that starts with one author (A) and then gets finished by another (B).
Let's say A starts the development, then falls sick or goes on holidays and B finishes the work.
Now, A cannot approve the PR even though he's not the last person to have worked on it (and no longer the main developer).
I'm wondering how to fix this and I see two potential solutions but I'm not sure I understand all the consequences (in terms of security) so thoughts on this would be appreciated:
Note: there's another discussion that points that B can commit to the PR, approve and merge and A now has their name on a commit that doesn't do what he developed (security issue?). I think the two issues are linked but the proposed solution that there should be a third reviewer to approve doesn't quite cut it as the team can get short on reviewers and this is blocking where some teams are mature enough (or codebases not sensitive enough...) to require more flexibility.
Beta Was this translation helpful? Give feedback.
All reactions