GitHub Community
Make it clear that "PENDING" comments have to be submitted #10369
Replies: 95 comments 70 replies
-
@medallyon - Any chance you would be willing to share what you learned? How do I properly submit my review so that these comments go away? UPDATE: After much looking, I found the place to "Submit" my review on the "files changed" tab in the upper right hand corner. |
Beta Was this translation helpful? Give feedback.
-
|
where is file changed? |
Beta Was this translation helpful? Give feedback.
-
|
this is completely woooowful |
Beta Was this translation helpful? Give feedback.
-
|
I'm still a little confused. So if I have pending suggestions / comments, when I submit my review, should I choose 'comment', 'approve' or 'request changes' ? |
Beta Was this translation helpful? Give feedback.
-
|
terrible wth |
Beta Was this translation helpful? Give feedback.
-
|
Chiming in. This resulted in a change request going unnoticed followed by a code merge. Meanwhile I'm staring at the comment completely perplexed as to how it got missed. Thanks to folks who investigated this -- definitely could use improvement. |
Beta Was this translation helpful? Give feedback.
-
|
Having to submit my replies to comments on my own PR is very unintuitive in general. But I agree with the original post, it should be more clear that you're in a 'session' that needs to be closed. |
Beta Was this translation helpful? Give feedback.
-
|
just ran into this myself. horrible experience |
Beta Was this translation helpful? Give feedback.
-
|
Same, it was pending for a few days and then the person who submitted the pr said he couldn't see it. Definitely needs more clarity. |
Beta Was this translation helpful? Give feedback.
-
|
Please fix it, I want to reply to other comments without submitting my review yet |
Beta Was this translation helpful? Give feedback.
-
|
Yeah... this is mega confusing for newer GitHub users. Here's an example where a newer user tells me "But Mike, I've reviewed your PR." And except for the "pending" label, it looks like it! Seriously. "Pending" is a poor choice of words. For so many GitHub users, "pending" sounds like legalese. I'd replace "pending" with something like:
Or maybe with an (i) (info) pop-up that says "To share your comments with the author, select Review changes" (or "Finish your review", depending on the status) |
Beta Was this translation helpful? Give feedback.
-
|
YESSSSS!! So True! The |
Beta Was this translation helpful? Give feedback.
-
|
I totally agree, and IMO "Draft" is the right word to use. With a tooltip explaining what it means! |
Beta Was this translation helpful? Give feedback.
-
|
draft would be the PERFECT word to use in this scenario... i don't see why this hasn't been changed yet... |
Beta Was this translation helpful? Give feedback.
-
|
Since @github-staff has yet to respond, I've posted a related Tweet: https://twitter.com/TheMikeJang/status/1562789398034276353?s=20&t=Q9Law9XkEM4WagPewd7AaQ |
Beta Was this translation helpful? Give feedback.
-
|
I've fallen into the same pitfall after a few years not using githuvb reviews 🤦 The Inspiration: the slackbot's |
Beta Was this translation helpful? Give feedback.
-
|
Yes! Please let's do this! The current wording with pending is very misleading, as one can interpret it as "a response from the others is pending". And it's totally not clear, that such pending reviews need to be published. |
Beta Was this translation helpful? Give feedback.
-
|
such a freaking flow. If you just press green button "add review comment" doesn't mean you actually make a comment, you have to submit your comment as well... omg ps should I submit something after pressing "answer" button here? |
Beta Was this translation helpful? Give feedback.
-
|
Ow please yes, change that to be clear in comments. I requested some reviews, but I didn't realize is marked "Pending". 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Happened to me as well, I replied to the reviews and after many days the maintainer made me realize that my comments are PENDING and not even visible to them. Really bad design, Github should definitely make it more intuitive |
Beta Was this translation helpful? Give feedback.
-
|
Yep that just got me too. Here I was wondering why my colleagues hadn't addressed my comments ... because of course they hadn't seen them. Yet another way I dislike Github's PR experience 😡 |
Beta Was this translation helpful? Give feedback.
-
|
I just realized it today after 2 months of being neglected of the reviews... |
Beta Was this translation helpful? Give feedback.
-
|
yes, I meet it |
Beta Was this translation helpful? Give feedback.
-
|
This is just incredible... |
Beta Was this translation helpful? Give feedback.
-
|
The first time it happened to me, my teammate had to message me that he didn't see my comments on his PR. (I was glad I told him I wrote some comments, or I wouldn't have figured it out.) And sometimes my comments would become outdated by the time they are submitted, because the user had already updated the code. |
Beta Was this translation helpful? Give feedback.
-
|
Same happens to me.. |
Beta Was this translation helpful? Give feedback.
-
|
It's probably worth clarifying that the OP is talking about comments by the author of PR: in github, if I'm the author of a PR, and I reply to a reviewer's comments, all my comments show as Pending, until I, as the author, go to the Files tab and click Submit Review. Note that when I'm author, the Submit Review dialog does not allow anything but the Comment option to be selected. The weirdest thing for me is that I've never noticed this until today, so I'm wondering how they heck my colleagues saw my responses, maybe they didn't!!! Or maybe this is a recent change Jan 2022 (although today is Jan 2024!). But as a reviewer, if it happens that I add a comment, and then further down in the review I understand something so I scroll back up and edit or entirely remove my now-irrelevant/wrong comment, then when I'm done adding comments I click Submit. This has been very handy many many times, and it's awesome that github has this. Therefore, for a reviewer it makes 100% sense to first add all comments, and then submit them as a batch or transaction. BUT NOT FOR THE PR AUTHOR. As an author, I expect a reply to a comment left by a reviewer to be immediate, and have never in years of using github, wished I could have my author comments pending. Update: |
Beta Was this translation helpful? Give feedback.
-
|
👋🏼 me again, thank you to everyone who has shared their feedback and experiences on this thread, I do not have an update per se, but we value transparency and want to be upfront about expectations on this thread going forward. Due to the volume and nature of questions, GitHub staff will no longer be responding to individual pings on this thread. This is not to say the request is or is not being worked on - just that you will no longer get a response when @ mentioning myself or another Hubbers. In our release process, we ensure that information is shared publicly once a feature is officially on the roadmap. This means that we’re unable to share details like feasibility, timelines, T-shirt sizing, and other specifics related to the request in these discussions, particularly when fixes or improvements may be part of larger projects or shipments. While we understand this might be unsatisfying, our primary goal is to be upfront and transparent, ensuring we provide you with clear and concise information. We believe that this approach will help avoid any potential frustration that could arise from vague or incomplete discussions. Thank you for taking the time to share your thoughts with us. Your input is valuable and contributes to the continuous improvement of GitHub so please do not hesitate to keep adding it here. |
Beta Was this translation helpful? Give feedback.
-
|
Stop saying you value transparency when you aren't being transparent. Transparency means something like "we want to work on it next month" or "not realistic for this year, maybe next year" or "maybe it will get on the roadmap in Q2, maybe we won't" or "Internally, Bob Doe is advocating for this but there are too many other priorities". Come on. Be better than this. |
Beta Was this translation helpful? Give feedback.
-
|
Unfortunately this is only as transparent as a black box inside a glass box. We were very clearly informed that we won't be getting any information whatsoever. 🤐 |
Beta Was this translation helpful? Give feedback.
-
|
@szalapski @pantherdd, I think they are being transparent. They've stated that it is a known issue that is being considered and thought about but it is not on the timeline because they cannot commit to its completion. I think that it makes sense. If they were to say some tentative or aspirational timeline, they might slip and receive backlash. We do not know why it hasn't been implemented yet, it could be any myriad of valid reasons. Its a tough spot for us who want this feature; for the support team who is trying their best to graciously handle these situations with whatever information they have; and for the developers who are trying to find ways to make this better without breaking existing workflows. I think we need to give everyone the benefit of the doubt and accept that things are the way that they are for the moment. If we are not happy we can use other platforms, otherwise we need to lay in this bed and trust that everyone will do their best. |
Beta Was this translation helpful? Give feedback.
-
|
@jtamagnan-delphix
I may have missed it, can you share where it was stated that it "is being considered and thought about"? All I could find was these:
What I see here is the classic "neither confirm nor deny" on every aspect of fixing this problem. All we know is that an internal issue was created for it. Again, I may have missed something. In my opinion, this complete lack of expectation setting is the worst possible state to be in, I personally would even prefer a "we won't even consider this until our next Roadmap Review in July" kind of update over it. In that case I'd at least know to not even hope for anything for another 5 months. |
Beta Was this translation helpful? Give feedback.
-
|
Holy mother of christ, the ux in this feature is terrible. How come it doesn't bother anyone at GitHub? Unbelievable |
Beta Was this translation helpful? Give feedback.
-
|
This got me too just now. It's a good feature, but it should be more clear. Maybe add a tooltip on the tag or something like that. And make it obvious from the 'submit' button that it will not be final would also be a huge help. |
Beta Was this translation helpful? Give feedback.
-
|
It's been over 2 years and this is still tripping people. Possibly most recently me. Sigh. |
Beta Was this translation helpful? Give feedback.
-
|
Is so counterintuitive. I just want to write a comment and I cannot! |
Beta Was this translation helpful? Give feedback.
-
|
I have created two support tickets, it's has been 15+ days with no response from the support team, actually, my account was flagged and I don't even know the reason!! Can anyone let me know where I can get a sooner reply as my campus placements are starting..please help!! |
Beta Was this translation helpful? Give feedback.
-
|
And still not fixed... The worst UX possible, thanks for everyone who commented here otherwise I would have been none wiser! |
Beta Was this translation helpful? Give feedback.
-
|
I had to google "Why my GitHub comments are pending" and get here to know what actually happened. At least they can just fix the label in no time. Like c'mon, how would hovering to the word "Pending" showing "Label: Pending" help. |
Beta Was this translation helpful? Give feedback.
-
|
Please please send a reminder email to finish the review 10mins or so after you close the tab of an ongoing review. |
Beta Was this translation helpful? Give feedback.
-
|
I tripped on this second time and somehow I'm here, shhh |
Beta Was this translation helpful? Give feedback.
-
|
my previous companies used gitlab... just realized this after a year and half at my current company... this is sooo stupid... |
Beta Was this translation helpful? Give feedback.
-
|
If anyone is still wondering where to submit his comments
|
Beta Was this translation helpful? Give feedback.
-
|
Please fix this. At the very least, add a tooltip or link to "Pending" explaining this. |
Beta Was this translation helpful? Give feedback.
-
|
Apparently a new tooltip is a feature so complex that it requires careful planning, prioritization, and a public roadmap item. Delivery time is currently measured in years. |
Beta Was this translation helpful? Give feedback.
-
|
github moment |
Beta Was this translation helpful? Give feedback.
-
|
Ran into this issue. Such a bad user experience. Definitely it can be improved and be more intuitive. |
Beta Was this translation helpful? Give feedback.
and others
-
It just took me 2 months to figure out that the big, yellow "PENDING" decorator on my comments does NOT mean:
"Your comment is pending to be reviewed by the maintainer."
But it actually means:
"You haven't submitted your comment (along with your review)."
It took me some additional days to figure out how to "submit" the review. I was merely commenting on a review that the maintainer had already started and expected those comments to appear on the reviewer's end as soon as I clicked on "Comment".
See the following:
Beta Was this translation helpful? Give feedback.
All reactions