Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl plugin completions not working for kj, kjx, ky #12427

Closed
JtMotoX opened this issue May 17, 2024 · 2 comments
Closed

kubectl plugin completions not working for kj, kjx, ky #12427

JtMotoX opened this issue May 17, 2024 · 2 comments

Comments

@JtMotoX
Copy link

JtMotoX commented May 17, 2024

Describe the bug

The kj, kjx, and ky functions in the kubectl plugin are supposed to have completion but they are not working.

https://github.com/ohmyzsh/ohmyzsh/blob/a779d6563ffb2f0093b4b74c8d5ff0982fa3e930/plugins/kubectl/kubectl.plugin.zsh#L183C1-L192C3

Steps to reproduce

  1. Install jq and/or yh
  2. kubectl get pod [tab] = shows list of pods
  3. kj get pod [tab] = shows list of files and folders in my cwd
  4. ky get pod [tab] = shows strange ascii sequence
> kubectl get pod [tab]
apiservice-558d4678c8-rp4xx  docs-5d56b46dd5-qcrcn        uiservice-c6c947885-ghv8g

> kj get pod [tab]
CODE_OF_CONDUCT.md  README.md           completions/        log/                templates/                                              
CONTRIBUTING.md     SECURITY.md         custom/             oh-my-zsh.sh        themes/                                                 
LICENSE.txt         cache/              lib/                plugins/            tools/

> ky get pod [tab]
$'\033'\[30\;101m

Expected behavior

> kubectl get pod [tab]
apiservice-558d4678c8-rp4xx  docs-5d56b46dd5-qcrcn        uiservice-c6c947885-ghv8g

> kj get pod [tab]
apiservice-558d4678c8-rp4xx  docs-5d56b46dd5-qcrcn        uiservice-c6c947885-ghv8g

> ky get pod [tab]
apiservice-558d4678c8-rp4xx  docs-5d56b46dd5-qcrcn        uiservice-c6c947885-ghv8g

Screenshots and recordings

No response

OS / Linux distribution

AlmaLinux

Zsh version

5.8

Terminal emulator

ssh

If using WSL on Windows, which version of WSL

None

Additional context

No response

carlosala added a commit to carlosala/ohmyzsh that referenced this issue May 30, 2024
@carlosala
Copy link
Member

Thanks for the report, it should be working now!

@JtMotoX
Copy link
Author

JtMotoX commented May 30, 2024

Still not working

> omz version
master~1 (2c08d2b)
~/.oh-my-zsh @2c08d2b8 ----------------------------------------------------------
> ky get deploy $'\033'\[30\;101m

yogeshraja pushed a commit to yogeshraja/ohmyzsh that referenced this issue May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants