Fix False Reports of Using Legacy Assets #17934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e assetprocessor will trigger the OnCatalogAssetChanged event for using the legacy id any time it processes an asset. The legacy asset warning still exists in AssetProcessor code as GetProductAssetInfo doesn't get called for legacy asset unless a legacy asset is actually being used https://github.com/o3de/o3de/blob/development/Code/Tools/AssetProcessor/native/AssetManager/AssetCatalog.cpp#L1715-L1728 Signed-off-by: AMZN-Gene <genewalt@amazon.com>
forkercat
approved these changes
May 17, 2024
spham-amzn
approved these changes
May 17, 2024
AMZN-Gene
changed the title
gadams3
approved these changes
May 17, 2024
nick-l-o3de
approved these changes
May 18, 2024
AMZN-Gene
added a commit
to aws-lumberyard-dev/o3de
that referenced
this pull request
May 20, 2024
…t look up becauseassetprocessor will trigger the OnCatalogAssetChanged event for using the legacy id any time it processes an asset. The legacy asset warning still exists in AssetProcessor code as GetProductAssetInfo doesn't get called for legacy asset unless a legacy asset is actually being used https://github.com/o3de/o3de/blob/development/Code/Tools/AssetProcessor/native/AssetManager/AssetCatalog.cpp#L1715-L1728 (o3de#17934) Signed-off-by: AMZN-Gene <genewalt@amazon.com>
Thankyou! |
nick-l-o3de
pushed a commit
that referenced
this pull request
May 21, 2024
…t look up becauseassetprocessor will trigger the OnCatalogAssetChanged event for using the legacy id any time it processes an asset. The legacy asset warning still exists in AssetProcessor code as GetProductAssetInfo doesn't get called for legacy asset unless a legacy asset is actually being used https://github.com/o3de/o3de/blob/development/Code/Tools/AssetProcessor/native/AssetManager/AssetCatalog.cpp#L1715-L1728 (#17934) (#17937) Signed-off-by: AMZN-Gene <genewalt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing 2 of 3 legacy asset id warnings. When an asset is reprocessed, asset processor triggers a OnCatalogAssetChanged event. It triggers the event for both the normal asset id, and the legacy asset id equivalent even if the legacy asset id isn't ultimately used.
The legacy asset warning still exists, but only inside the AssetProcessor's GetProductAssetInfo(); this appears to only be called when a legacy asset is actually being processed.
How was this PR tested?
Fixes #17933