Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(devkit): formatFiles uses prettier v3 async api in context with prettier v2 which causes intermittent pipeline failures within tests #23501

Open
1 of 4 tasks
Hotell opened this issue May 17, 2024 · 0 comments
Assignees
Labels

Comments

@Hotell
Copy link
Contributor

Hotell commented May 17, 2024

Current Behavior

Expected Behavior

formatFiles should use API based on prettier versions, quick fix should be using synchronous API that exists within prettier v2 (which all nx workpsaces should be using).

If user has prettier v3 installed a fallback to @prettier/sync should happen under the hood.

GitHub Repo

microsoft/fluentui#31408

Steps to Reproduce

  1. check the issue and link to pipeline

Nx Report

Node   : 18.20.1
   OS     : darwin-arm64
   yarn   : 1.23.34
   
   nx                 : 17.3.2
   @nx/js             : 17.3.2
   @nx/jest           : 17.3.2
   @nx/linter         : 17.3.2
   @nx/eslint         : 17.3.2
   @nx/workspace      : 17.3.2
   @nx/devkit         : 17.3.2
   @nx/eslint-plugin  : 17.3.2
   @nx/node           : 17.3.2
   @nx/plugin         : 17.3.2
   @nrwl/tao          : 17.3.2
   typescript         : 4.7.4
   ---------------------------------------
   Local workspace plugins:
         @fluentui/workspace-plugin

Failure Logs

No response

Package Manager Version

yarn v1

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

Related issues #19519 cc @AgentEnder

@Hotell Hotell changed the title devkit: formatFiles uses prettier v3 async api in context with prettier v2 which causes intermittent pipeline failures within tests bug(devkit): formatFiles uses prettier v3 async api in context with prettier v2 which causes intermittent pipeline failures within tests May 17, 2024
@FrozenPandaz FrozenPandaz added the scope: misc Misc issues label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants