Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease version calculation doesn't consider commits #23445

Open
1 of 4 tasks
mpsanchis opened this issue May 16, 2024 · 0 comments
Open
1 of 4 tasks

Prerelease version calculation doesn't consider commits #23445

mpsanchis opened this issue May 16, 2024 · 0 comments

Comments

@mpsanchis
Copy link

Current Behavior

Releasing as "prerelease" does not consider commit history.

@jscutlery/semver had the same issue until this February 馃槄 jscutlery/semver#688

Expected Behavior

x.y.z should for instance be bumped to (x+1).y.z-preid.0 if the commit history has a breaking change and the release specifier is "prerelease"

GitHub Repo

No response

Steps to Reproduce

  1. Commit with feat or feat! (breaking change)
  2. Calculate version (nx release version ...)

Nx Report

Node   : 18.18.2
OS     : darwin-arm64
pnpm   : 8.10.0

nx                 : 18.3.3
@nx/js             : 18.3.3
@nx/jest           : 18.3.3
@nx/linter         : 18.3.3
@nx/eslint         : 18.3.3
@nx/workspace      : 18.3.3
@nx/devkit         : 18.3.3
@nx/eslint-plugin  : 18.3.3
@nx/playwright     : 18.3.3
@nx/plugin         : 18.3.3
@nx/react          : 18.3.3
@nrwl/tao          : 18.3.3
@nx/vite           : 18.3.3
@nx/web            : 18.3.3
typescript         : 5.4.2
---------------------------------------
Registered Plugins:
@jnxplus/nx-maven
...
---------------------------------------
Community plugins:
@jnxplus/nx-maven      : 0.42.1
@monodon/rust          : 1.4.0
@ngx/deploy-npm        : 7.1.0
@nx-go/nx-go           : 3.0.0
@nx-tools/nx-container : 5.2.0
---------------------------------------
Local workspace plugins:
         ...

Failure Logs

No response

Package Manager Version

pnpm 8.10.0

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants