Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule tasks. Use async timer #7189

Open
ksbhadani opened this issue May 13, 2024 · 0 comments
Open

Schedule tasks. Use async timer #7189

ksbhadani opened this issue May 13, 2024 · 0 comments

Comments

@ksbhadani
Copy link

nopCommerce version: > 4.5

Steps to reproduce the problem:

Schedule tasks are made async but there caller stacks are sync and that leads to threadpool starvation, refer below screen shots

TaskThread

image

I think we should use periodic timer here, so that it can use async methods
https://learn.microsoft.com/en-us/dotnet/api/system.threading.periodictimer?view=net-8.0

ScheduleTaskRunner
image

We should use async methods

@AndreiMaz AndreiMaz added this to the Version 4.80 milestone May 13, 2024
@AndreiMaz AndreiMaz changed the title Improvement to schedule tasks - use async timer Schedule tasks. Use async timer May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants