Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create production version with docker #52

Open
mtheoryx opened this issue Jun 3, 2018 · 5 comments
Open

Create production version with docker #52

mtheoryx opened this issue Jun 3, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@mtheoryx
Copy link
Collaborator

mtheoryx commented Jun 3, 2018

  • NPM script for production build, ala NPM Script to make production build of app #48
  • Dockerfile and docker compose versions for production
  • NPM package production pushes, instructions, and settings (need an npm official account/contributor to do this)
@mtheoryx
Copy link
Collaborator Author

mtheoryx commented Jun 3, 2018

I'm more than happy to help with this!

@mpaarating mpaarating added the enhancement New feature or request label Jun 4, 2018
@mtheoryx
Copy link
Collaborator Author

mtheoryx commented Jun 9, 2018

I should also add that we probably need an account for @noopkat or other maintainers/automation to push final, versioned Docker images to a public registry like Docker Hub.

I envision a versioned image where users can (and the following may or may not be 100% a working example yet):

docker run electric-io:1.0.0 -p 3000:3000 -d

And then they can hit localhost:3000 to get the default dashboard to start plugging in their stuff and building it out. Data persistence optional (but should be documented), simulating optional (also documented), and of course, we will still fully support a docker compose example, even when using the built/public image.

What do you all think? Anything you think I may be missing?

@noopkat
Copy link
Owner

noopkat commented Jun 26, 2018

I just closed #55 so let's continue the discussion here. I just tagged the first image as latest for now while we address @mtheoryx's suggestions in this issue.

@mtheoryx
Copy link
Collaborator Author

latest is the devil! (IMHO)

@noopkat
Copy link
Owner

noopkat commented Nov 15, 2018

one thought I also had was that we should add JavaScript minification to the production build also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants