Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card + Setting form validation #3

Open
noopkat opened this issue Apr 16, 2018 · 3 comments
Open

Card + Setting form validation #3

noopkat opened this issue Apr 16, 2018 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@noopkat
Copy link
Owner

noopkat commented Apr 16, 2018

Currently there is no validation on either the dashboard settings or the card settings forms.

@noopkat noopkat added bug Something isn't working help wanted Extra attention is needed labels Apr 16, 2018
@mtheoryx
Copy link
Collaborator

For validation, where would you like to see that happen at?

Here are some options, after digging around a bit:

  1. In the UI, at the component level (nice for error visibility, but tightly couples the UI to logic)
  2. In the action before server submission (still in the UI, but separated a bit more, makes testing a little easier)
  3. In the server layer, at the express level?
  4. In the server layer at the data interaction level (where we fs.write stuff).

I think this is a great idea but I would like to know the minimal solution you would be interested in before diving too much deeper. Cheers!

@noopkat
Copy link
Owner Author

noopkat commented Jun 3, 2018

hi @mpaarating 👋

I like option 2! Thoughts?

@mtheoryx
Copy link
Collaborator

mtheoryx commented Jun 3, 2018

Good Sunday Morning @noopkat !

I'm roberttables, but I'd love @mpaarating thoughts on this too :D

FWIW, I like option 2 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants