Accessibility

[acnorrisuk]

Looks like you've done a good job with making things accessible which is great! Looking through I found a couple of things which could be improved.

• The nav button should really be a <button> which toggles aria-expanded when it is clicked. It also needs an accessible name adding
• Opening the nav should trap focus inside the nav until it is closed via the button (or the escape key is pressed)
• Opening the modal should trap focus inside the modal until it is closed via the button (or the escape key is pressed)
• The modal close button should really be a <button>. It also needs an accessible name adding

If you want to find out more about these issues and how to fix them I'd recommend Rob Dodson's A11ycasts series on YouTube. https://www.youtube.com/playlist?list=PLNYkxOF6rcICWx0C9LVWWVqvHlYJyqw7g

[nisarhassan12]

@acnorrisuk 🙂 Thanks! a lot! for doing this deep accessibility review. I once did a lighthouse audit which gave me a score of 100 and also stated that there are a few things to check manually for accessibility and I think you pointed out most of them I will look into the A11casts series.