Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Listbox dynamic item give unknown type to item if Listbox is extended using extendVariants in Typescript #3027

Open
ameytessact opened this issue May 20, 2024 · 1 comment

Comments

@ameytessact
Copy link

NextUI Version

2.3.0

Describe the bug

A listbox component that is extended does not infer the types correctly.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

I have a simple Listbox that uses dynamic items as follows:

export const MentionsListBox = ({
  items,
}: {
  items: Array<Item>;
}) => {
  return (
    <Listbox items={items || []}>
      {(item) => (
        <ListboxItem>
          {item.label}
        </ListboxItem>
      )}
    </Listbox>
  );
};

I am getting an typescript error for the type of item.

Type '(item: Item) => JSX.Element' is not assignable to type 'CollectionChildren<unknown> | undefined'.
  Type '(item: Item) => JSX.Element' is not assignable to type '(item: unknown) => CollectionElement<unknown>'.
    Types of parameters 'item' and 'item' are incompatible.
      Type 'unknown' is not assignable to type 'Item'. ts(2322)

Here is how I've extended my Listbox component:

import {
  Listbox as NextListBox,
  ListboxItem as NextListboxItem,
  ListboxSection as NextListboxSection
} from '@nextui-org/listbox';
import { extendVariants } from '@nextui-org/react';

export const Listbox = extendVariants(NextListBox, {
  defaultVariants: {
    variant: 'default'
  },
  variants: {
    variant: {
      default: {
        base: 'p-2 bg-ds-menu-bg border-ds-menu-border border rounded-xl',
        list: 'space-y-1'
      }
    }
  }
});

export const ListboxItem = extendVariants(NextListboxItem, {
  defaultVariants: {
    variant: 'default'
  },
  variants: {
    variant: {
      default: {
        base: 'bg-transparent data-[hover=true]:bg-ds-menu-bg-hover',
        description: 'text-ds-menu-text-secondary'
      }
    }
  }
});
export const ListboxSection = extendVariants(NextListboxSection, {});

Expected behavior

This error gets fixed automatically if I use the next ui component directly as such:

import { Listbox, ListboxItem } from '@nextui-org/react';

item also get the correct type inferred instad of unknown

I expect the extended component to infer the type correctly as well.

Screenshots or Videos

No response

Operating System Version

Ubuntu 24.04

Browser

Chrome

@ameytessact ameytessact changed the title [BUG] - Listbox dynamic item give unknown type to item if Listbox is exteded using extendVariants in Typescript [BUG] - Listbox dynamic item give unknown type to item if Listbox is extended using extendVariants in Typescript May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant