-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Building with --prefix=/foo
installs files to /foo/usr
when it should not do so.
#13242
Comments
Also, keep in mind the var location is also technically wrong, it goes to /usr/local/var/run/netdata but no freebsd port that i know of uses anything like this and instead uses /var, i.e. /var/db/netdata, /var/run, /var/cache/netdata, or /var/log/netdata. This isn't as much of a deal as the other issue but thought id mention it. |
That’s a very good point, and we will actually need to fix it eventually, though it will likely be more involved than just patching the build system. |
If it helps, you can see how the port patches the installer to use appropriate directories here. https://github.com/freebsd/freebsd-ports/tree/main/net-mgmt/netdata More specifically this file https://github.com/freebsd/freebsd-ports/blob/main/net-mgmt/netdata/files/patch-configure.ac |
Quick update on this. It looks like The |
Hey @Ferroin , do we have any planes on fixing this one? Also, do we need a separate ticket for the |
The I’ve got the beginnings of a fix for the |
Bug description
When building the agent with a prefix, we install files into
usr
under that prefix, even though we should not be doing so.For example, if installing to
/usr/local
as a prefix, the binaries end up in/usr/local/usr/bin
and/usr/local/usr/sbin
, instead of/usr/local/bin
and/usr/local/sbin
like they should.Expected behavior
Installing in a prefix puts the files in the correct locations.
Steps to reproduce
Installation method
any
System info
Netdata build info
Additional info
Supersedes: #12430
Relevant to: #13230
Fixing this requires changes to the configure scripts themselves so that installing to a prefix puts anything that would normally go under
/usr
under the root of that prefix.The text was updated successfully, but these errors were encountered: