Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language provider errors are ignored #89

Closed
Gaming32 opened this issue Feb 13, 2024 · 1 comment
Closed

Language provider errors are ignored #89

Gaming32 opened this issue Feb 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Gaming32
Copy link
Contributor

If a language provider isn't present, an errors list is created and passed to the sorter.

var errors = validateLanguages();
var allErrors = new ArrayList<>(errors);
allErrors.addAll(this.discoveryErrorData);
loadingModList = ModSorter.sort(candidateMods, allErrors);

However, ModSorter.sort completely ignores its second argument, leading to missing language providers (modLoaders) simply skipping mods with no more than a logged error message. The language can't even be put into dependencies, because mods with erroring language providers get entirely removed from the mod list (before dependencies are checked).

@sciwhiz12 sciwhiz12 added the bug Something isn't working label Apr 26, 2024
@Matyrobbrt
Copy link
Member

Fixed in 0844898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants