Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IModLanguageProvider#loadMod signature is really weird #72

Closed
Technici4n opened this issue Jan 15, 2024 · 1 comment
Closed

IModLanguageProvider#loadMod signature is really weird #72

Technici4n opened this issue Jan 15, 2024 · 1 comment
Labels

Comments

@Technici4n
Copy link
Member

The signature is:

    interface IModLanguageLoader {
        <T> T loadMod(IModInfo info, ModFileScanData modFileScanResults, ModuleLayer layer);
    }

however T should actually be ModContainer, which is NOT part of the SPI. A bit tricky to handle I think.

@Matyrobbrt
Copy link
Member

Fixed in 9cf72d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants