Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Early loading screen loading sequence triggers load of Minecraft classes prior to launch #17

Open
cpw opened this issue Aug 20, 2023 · 4 comments
Open

Early loading screen loading sequence triggers load of Minecraft classes prior to launch #17

cpw opened this issue Aug 20, 2023 · 4 comments
Assignees
@cpw
Labels
bug Something isn't working

Comments

@cpw
Copy link
Member

cpw commented Aug 20, 2023

DisplayWindow forces minecraft classes to load too early in the "updateModuleReads" method. This needs to be refactored to not classload anything prior to actual launch.
@cpw cpw self-assigned this Aug 20, 2023
@Technici4n
Copy link
Member

How problematic is this in practice?

@marchermans
Copy link
Contributor

How problematic is this in practice?

Those classes are not coremoddable

@Technici4n
Copy link
Member

Interesting - they should be on the game layer already, so I would have expected them to be coremoddable.

@Technici4n
Copy link
Member

I just tested and NeoForgeLoadingOverlay can be targeted fine with a mixin. @cpw can you elaborate on the issue?

@Shadows-of-Fire Shadows-of-Fire added the bug Something isn't working label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpw cpw

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cpw @Shadows-of-Fire @marchermans @Technici4n