Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Federation shared deep dependency resolved incorrectly #2033

Open
tzachbon opened this issue Jun 21, 2022 · 1 comment
Open

Module Federation shared deep dependency resolved incorrectly #2033

tzachbon opened this issue Jun 21, 2022 · 1 comment

Comments

@tzachbon
Copy link

Repo that reproduces the issue - https://github.com/tzachbon/mf-shared-deep-dependency

This example tries to reproduce the problem when sharing a dependency that exists in multiple versions across the node modules but resolves the request incorrectly.

In this example repo, I use uuid package.

└─┬ @startup-code/app1@0.0.0 -> ./app1
  ├─┬ lib@1.0.0 -> ./lib
  │ └── uuid@3.4.0
  ├── uuid@8.3.2
  └─┬ webpack-dev-server@4.8.1
    └─┬ sockjs@0.3.24
      └── uuid@8.3.2 deduped

This graph shows that the root uuid is 8.3.2 and the version under lib is 3.4.0.

lib uses the v3 method from uuid.
This method exists only in version 8.3.2.

By default, if we build this project, serve it and click on new uuid, everything crashes as expected:
console

But when we use Module Federation and share this package from app1 like this:

[
      new ModuleFederationPlugin({
      name: 'app1',
      shared: {
        lib: deps['lib'],
        uuid: deps['uuid'], // <-- resolve to ^8.3.2
        react: { singleton: true, requiredVersion: deps.react },
        'react-dom': { singleton: true, requiredVersion: deps['react-dom'] },
      },
    })
]

We can see that the runtime understands the difference between the packages:
runtime

But when we click on new uuid which crashed our app, it works (not the desired behavior)...
console

When we look inside the index file, we can see the moduleToHandlerMapping resolve it incorrectly:
moduleToHandlerMapping

And when we remove the uuid entry from the shared section in ModuleFederationPlugin we can see that the app behaves as expected:
console

For some reason, even when it is explicitly defined to be shared with ^8.3.2, it matches the 3.4.0 version that lib consumes.

Debug stats:

webpack: 5.72.1
node: v16.15.0
npm: 8.5.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant