Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authProviderOptions folder seems to be missing and causing compilation warning #1385

Open
hesperanca opened this issue Aug 4, 2023 · 7 comments
Assignees

Comments

@hesperanca
Copy link

Bug Report

Prerequisites

  • [X ] Can you reproduce the problem?
  • [ X] Are you running the latest version?
  • [ X] Are you reporting to the correct repository?
  • [ X] Did you perform a cursory search?

For more information, see the CONTRIBUTING guide.

Description

I'm getting the following compilation warning:

WARNING in ./node_modules/@microsoft/microsoft-graph-client/authProviders/authCodeMsalBrowser/index.js
Module Warning (from ./node_modules/source-map-loader/dist/cjs.js):
Failed to parse source map from 'C:\Projects\Obedis\src\Frontend\Obedis.Cockpit\node_modules@microsoft\microsoft-graph-client\authProviderOptions\authCodeMsalBrowser\index.ts' file: ErrCompiled with warnings.

I've checked under the node modules folder in the file system and the "authProviderOptions" folder does not exist.
I've re-installed the component but still getting the same error.

Many thanks in advanced

@sebastienlevert
Copy link
Contributor

Can you share a super small repro so we can have a look at it? I wasn't able to reproduce. Thanks!

@yiqing-zhao
Copy link

yiqing-zhao commented Aug 8, 2023

Same issue here, in my case, I was trying to use @microsoft/microsoft-graph-client in a react app. @sebastienlevert, here are the repro steps:

  1. Run npx create-react-app my-app --template typescript and cd my-app.
  2. Run npm install @microsoft/microsoft-graph-client @azure/identity@2.1.0. In my case, I installed @microsoft/microsoft-graph-client@3.0.5 and @azure/identity@2.1.0
  3. In file App.tsx, update the code as follows:
import React from 'react';
import logo from './logo.svg';
import './App.css';
import { InteractiveBrowserCredential } from "@azure/identity";
import { Client } from "@microsoft/microsoft-graph-client";
import { TokenCredentialAuthenticationProvider } from "@microsoft/microsoft-graph-client/authProviders/azureTokenCredentials";

function App() {
  const credential = new InteractiveBrowserCredential({
    clientId: "YOUR_CLIENT_ID",
    tenantId: "YOUR_TENANT_ID",
  });
  const authProvider = new TokenCredentialAuthenticationProvider(credential, {
    scopes: ["User.Read"],
  });
  const client = Client.initWithMiddleware({ authProvider });
  return (
    <div className="App">
      <header className="App-header">
        <img src={logo} className="App-logo" alt="logo" />
        <p>
          Edit <code>src/App.tsx</code> and save to reload.
        </p>
        <a
          className="App-link"
          href="https://reactjs.org"
          target="_blank"
          rel="noopener noreferrer"
        >
          Learn React
        </a>
      </header>
    </div>
  );
}

export default App;
  1. Run npm run start. Then, the warning appears. Please ignore the warning of no-unused-vars.
    image

@sebastienlevert
Copy link
Contributor

Thanks @yiqing-zhao for the repro, I was able to get this reproduced. It seems to be an ESM issue that doesn't appear in CJS. @koros please have a look as this is really impacting developers right now. Thanks.

@hesperanca
Copy link
Author

Thanks @yiqing-zhao. You beat me to it. Things are mad here and I haven't had a chance to create a repro for @sebastienlevert. One less thing on my task list 😊

@koros
Copy link
Contributor

koros commented Aug 9, 2023

@yiqing-zhao I am currently looking into this. I'll give an update soon

@sgauthier25
Copy link

Hello everyone,

Do you have a date when a fix will be provided?

@koros
Copy link
Contributor

koros commented Sep 4, 2023

Hello everyone,

Do you have a date when a fix will be provided?

It should be addressed in ver 3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants