Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Redis Memory Connector should allow for filtering when searching #6159

Open
engt21 opened this issue May 8, 2024 · 1 comment
Open
Labels
enhancement python Pull requests for the Python Semantic Kernel

Comments

@engt21
Copy link

engt21 commented May 8, 2024

As related to my investigations of the Python redis memory connector in #6084 and #6088, the redis memory connector by default only goes *=> to do the search. This will return all the keys in the store. However, there should be an option for the user to allow them to provide a key to filter on, much like in native redis. Although you can pass in the collection name, this allows for greater granularity and accuracy of RAG, especially for large applications that have similar values and many k-v pairs stored.

We found that when we had key value pairs with similar or nearly identical values, even when passing the collection name in, we got poor performance, unless we modified the filter.

@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel triage labels May 8, 2024
@matthewbolanos
Copy link
Member

@westey-m, adding you here so that you have context of some of the requests coming in for memory (in case it helps with creating the abstraction).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

No branches or pull requests

3 participants