Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: --ui mode doesn't respect --output as of 1.43 #30886

Closed
CreativeTechGuy opened this issue May 18, 2024 · 1 comment · Fixed by #30941
Closed

[Bug]: --ui mode doesn't respect --output as of 1.43 #30886

CreativeTechGuy opened this issue May 18, 2024 · 1 comment · Fixed by #30941
Assignees
Labels

Comments

@CreativeTechGuy
Copy link

Version

1.44.0

Steps to reproduce

  1. Create a new project with the minimal playwright setup (the contents of the tests don't matter).
  2. Run playwright test --ui --output=some/other/path
    a. When you close the UI, the output will not be generated at the specified path
  3. Run playwright test --output=some/other/path
    a. When the tests end, the output will be at the specified path

Expected behavior

I'd expect the --output option to be respected as it was before 1.43.0

Actual behavior

The --output option is ignored when running with --ui

Additional context

This also affects testInfo.outputPath() from within a test fixture but I assume this is all due to the same root issue.

Environment

System:
    OS: Windows 10 10.0.19045
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 7.55 GB / 15.95 GB
  Binaries:
    Node: 20.13.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.5.2 - C:\Program Files\nodejs\npm.CMD
  IDEs:
    VSCode: 1.89.1 - C:\Users\User\AppData\Local\Programs\Microsoft VS Code\bin\code.CMD
  Languages:
    Bash: 4.4.23 - C:\Program Files\Git\usr\bin\bash.EXE
  npmPackages:
    @playwright/test: ^1.44.0 => 1.44.0
@CreativeTechGuy
Copy link
Author

Thank you so much for the fast turnaround on this fix! Is there an ETA for 1.45.0 being released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants