Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpprest_compat breaks cURL header when building with Clang 14 #1710

Open
lilianmoraru opened this issue Jun 27, 2022 · 3 comments · May be fixed by #1723
Open

cpprest_compat breaks cURL header when building with Clang 14 #1710

lilianmoraru opened this issue Jun 27, 2022 · 3 comments · May be fixed by #1723

Comments

@lilianmoraru
Copy link

#define dllimport inside cpprest_compat.h breaks curl.h on Clang 14.

See minimized example here: godbolt

The issue was initially reported to LLVM.
The LLVM issue was closed. For the reason, see these comments: comment1 and comment2.
@barcharcraz
Copy link
Member

Yeah I can see why they closed that one. This header is pretty horrible.

@liam-x liam-x linked a pull request Oct 7, 2022 that will close this issue
Open
@laveur
Copy link

laveur commented Nov 8, 2022

FYI this project is now dead. You should move away from cpprest ASAP. See the readme file.

@barcharcraz
Copy link
Member

Indeed, we will fix any super critical bugs, but we highly, highly, highly recommend folks move to another library. We usually recommend libcurl.

russelltg added a commit to russelltg/vcpkg that referenced this issue May 9, 2024
@russelltg
[cpprestsdk] fix clang build on new zlib
b5d2ac3 
definint dllimport is *bad* and breaks clang, and since this is in maintaince mode they aren't going to fix it.  Refs:

microsoft/cpprestsdk#1710
llvm/llvm-project#53269
@russelltg russelltg mentioned this issue May 9, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workaround clang 14 __has_declspec_attribute restriction liam-x/cpprestsdk
3 participants
@lilianmoraru @laveur @barcharcraz