Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIR-V] Hitting max ID bound #6636

Open
maj-tom opened this issue May 17, 2024 · 0 comments · May be fixed by #6654
Open

[SPIR-V] Hitting max ID bound #6636

maj-tom opened this issue May 17, 2024 · 0 comments · May be fixed by #6654
Assignees
Labels
bug Bug, regression, crash spirv Work related to SPIR-V

Comments

@maj-tom
Copy link

maj-tom commented May 17, 2024

In my application I often exceed kDefaultMaxIdBound, how to best deal with this? My understanding is that this is just the minimum bound required by the specification, so how to override it? As a quick test if I put a higher value in this constant it avoids my problem, but since the value is given by the spec, this seems not the correct solution

@maj-tom maj-tom added bug Bug, regression, crash needs-triage Awaiting triage spirv Work related to SPIR-V labels May 17, 2024
@s-perron s-perron removed the needs-triage Awaiting triage label May 21, 2024
@s-perron s-perron self-assigned this May 21, 2024
s-perron added a commit to s-perron/DirectXShaderCompiler that referenced this issue May 27, 2024
Vulkan implementation can have different limits on the maximum value
used as an id in a SPIR-V binary. SPIRV-Tools generall assumes this
limit is 0x3FFFFF because all implementations must support at least that
value for an id.  Since many implementations can support larger values,
the tools allows an option that will set a different limit. This commit
add an option to DXC to do the same.

Fixes microsoft#6636
@s-perron s-perron linked a pull request May 27, 2024 that will close this issue
s-perron added a commit to s-perron/DirectXShaderCompiler that referenced this issue May 27, 2024
Vulkan implementation can have different limits on the maximum value
used as an id in a SPIR-V binary. SPIRV-Tools generall assumes this
limit is 0x3FFFFF because all implementations must support at least that
value for an id.  Since many implementations can support larger values,
the tools allows an option that will set a different limit. This commit
add an option to DXC to do the same.

Fixes microsoft#6636
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash spirv Work related to SPIR-V
Projects
Status: Triaged
Development

Successfully merging a pull request may close this issue.

2 participants