[SPIR-V] Address "unsupported" tests #6616
Comments
sudonatalie
added
spirv
sudonatalie
added a commit
to sudonatalie/DirectXShaderCompiler
that referenced
this issue
May 15, 2024
These tests were previously marked as "unsupported" because they were misconfigured at the time they were added and never run. Minor changes have been made to make them passing tests. Note that rayquery_assign.cs.hlsl has been removed because it no longer produces an error. A similar non-erroring check exists in rayquery_init_expr.hlsl Related to microsoft#6616
This was referenced May 15, 2024
sudonatalie
added a commit
to sudonatalie/DirectXShaderCompiler
that referenced
this issue
May 16, 2024
This test fails to compile both for SPIR-V and for DXIL with: "error: cannot implicitly convert from 'SecondStruct' to 'FirstStruct'". If it would have succeeded at some point in the past it's no longer valid anyways, so removing it. Related to microsoft#6616
s-perron
pushed a commit
that referenced
this issue
May 17, 2024
This test is marked as unsupported (ignored), but it currently fails to compile both for SPIR-V and DXIL with the same Sema error: "cannot implicitly convert from 'SecondStruct' to 'FirstStruct'". If it would have succeeded for SPIR-V at some point in the past it's no longer valid anyways, so removing it. Related to #6616
sudonatalie
added a commit
that referenced
this issue
May 17, 2024
These tests were previously marked as "unsupported" because they were misconfigured at the time they were added and never run. Minor changes have been made to make them passing tests. Note that rayquery_assign.cs.hlsl has been removed because it no longer produces an error. A similar non-erroring check exists in rayquery_init_expr.hlsl Related to #6616
sudonatalie
added a commit
that referenced
this issue
May 17, 2024
The following tests only required minor test syntax changes to pass: - tools/clang/test/CodeGenSPIRV/cast.2float.interlocked.hlsl - tools/clang/test/CodeGenSPIRV/meshshading.nv.error.fncall.amplification.vulkan1.2.hlsl (+ replacing NV ext with EXT) - tools/clang/test/CodeGenSPIRV/var.init.extvector.hlsl Issue #6621 has been filed to track the failure of tools/clang/test/CodeGenSPIRV/oo.class.static.member.hlsl. Related to #6616
sudonatalie
added a commit
to sudonatalie/DirectXShaderCompiler
that referenced
this issue
May 17, 2024
This test was marked DISABLED_ in Gtest at the time it was added in PR microsoft#3155, so it appears that it was never passing. I don't think it's a high-priority to implement at this point, so opting to simply remove it. This is the last test in the unsupported directory so it can now be removed entirely. Fixes microsoft#6616
sudonatalie
added a commit
that referenced
this issue
May 21, 2024
This test was marked DISABLED_ in gtest at the time it was added in PR #3155, so it appears that it was never passing. Specifically, the CHECK for `DebugFunction [[func1]]` fails. I don't think it's a priority to implement debug info for unreferenced functions at this point, so opting to simply remove it. This is the last test in the unsupported directory so it can now be removed entirely. Fixes #6616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of the Lit migration, a number of SPIR-V backend tests were found that were not actually being run, so they were placed in
tools/clang/test/CodeGenSPIRV/unsupported. We should address these tests individually and either fix them up to be run and passing or remove them if they're not relevant.The text was updated successfully, but these errors were encountered: