Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skill bot should create eoc as an activity, as IEndOfConversation doesn't have a Value property #3091

Open
JonathanFingold opened this issue Feb 18, 2021 · 1 comment
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@JonathanFingold
Copy link
Contributor

JonathanFingold commented Feb 18, 2021

Sample information

  1. Sample type: [samples]
  2. Sample language: [dotnetcore]
  3. Sample name: 80.skills-simple-bot-to-bot/EchoSkillBot (probably in sample 81, too)

Describe the bug

With the current code, need to jump through hoops to set the Value property on the end of conversation activity. This is an issue because we tell developers to use the Value property as return value when the skill ends.

To Reproduce

Steps to reproduce the behavior:

  1. Edit the skill bot in the simple skill sample.
  2. After creating the end of conversation activity (as written in the sample), try to assign to its value property.
  3. See error (compiler warning, as there is no such property on the IEndOfConversation type).

Expected behavior

Can assign a value to the activity.

Additional context

// Send End of conversation at the end.
var messageText = $"ending conversation from the skill...";
await turnContext.SendActivityAsync(MessageFactory.Text(messageText, messageText, InputHints.IgnoringInput), cancellationToken);
var endOfConversation = Activity.CreateEndOfConversationActivity();
endOfConversation.Code = EndOfConversationCodes.CompletedSuccessfully;
await turnContext.SendActivityAsync(endOfConversation, cancellationToken);

@JonathanFingold JonathanFingold added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Feb 18, 2021
@JonathanFingold JonathanFingold added the Area: Skills The issue is related to skills label Feb 18, 2021
@JonathanFingold
Copy link
Contributor Author

After talking to Srinaath and TJ, it looks like the end dialog action in the skill does generate an endOfConversation activity, and there is a way to set the generated activity value property. There doesn't seem to be a way to set the generated activity code property, however.

@carlosscastro carlosscastro added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Skills The issue is related to skills bug Indicates an unexpected problem or an unintended behavior. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Development

No branches or pull requests

3 participants