Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definitions #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TypeScript definitions #70

wants to merge 1 commit into from

Conversation

iddan
Copy link

@iddan iddan commented Jun 21, 2022

This is not a complete definition but it was good enough to get me going.
Closes #64

@mheap
Copy link
Owner

mheap commented Sep 30, 2022

Hey @iddan, I couldn't get this working for me in VS Code. Could you share any more guidance?

@iddan
Copy link
Author

iddan commented Oct 2, 2022

Hey @mheap what is the issue you are experiencing?

@mheap
Copy link
Owner

mheap commented Oct 2, 2022

I ran npm link with your fork and the typings were not showing up as expected when I imported the module

@iddan
Copy link
Author

iddan commented Oct 2, 2022

I see. I don't have the capacity right now to check but the types are extracted from my code repository

@mheap
Copy link
Owner

mheap commented Oct 16, 2022

I had a go at this. Type definitions generated with rm *.d.ts; npx tsc on this branch: https://github.com/mheap/octokit-commit-multiple-files/tree/add-types

I'm struggling how to extend the octokit definitions to include createOrUpdateFiles(). Module augmentation looks promising, but I couldn't get it working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide TypeScript Definition
2 participants