Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message attachment markdown does not show plugin tooltips #27065

Open
mattermod opened this issue May 20, 2024 · 2 comments
Open

Message attachment markdown does not show plugin tooltips #27065

mattermod opened this issue May 20, 2024 · 2 comments
Assignees
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/ReactJS Web app

Comments

@mattermod
Copy link
Contributor

In order for plugin link tooltips to work correctly with the Markdown component, we must pass the hasPluginTooltips prop as shown here:

https://github.com/mattermost/mattermost/blob/099f704d4ff769ff40e1bced5411874dec156766/webapp/channels/src/components/post_markdown/post_markdown.tsx#L126

Here we are using the Markdown React component in the MessageAttachment component, and not providing this prop:

https://github.com/mattermost/mattermost/blob/099f704d4ff769ff40e1bced5411874dec156766/webapp/channels/src/components/post_view/message_attachments/message_attachment/message_attachment.tsx#L354

You can reproduce this on the community server if your MM account is connected to Jira with this post https://community.mattermost.com/core/pl/rxh5d7ieibr79q578phk5qojma. Hovering over the Jira ticket URL results in no tooltip showing. This is because this text is in the pretext of a message attachment, as opposed to a regular post message. Notice that hovering over the link in the next post below triggers the tooltip.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-58189

@mattermod mattermod added Help Wanted Community help wanted Up For Grabs labels May 20, 2024
@Ari1009
Copy link

Ari1009 commented Jun 4, 2024

image
Did you mean it in this manner? Is there any video or screenshot that provides visual clarity on the issue? Thanks.

@MReza8
Copy link

MReza8 commented Jun 6, 2024

can i work on this, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/2:Medium Medium ticket Help Wanted Community help wanted Tech/ReactJS Web app
Projects
None yet
Development

No branches or pull requests

5 participants