You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I'm trying to post a message which contains mattermost.PostMessageMaxRunesV2 + 1 of symbols, I receive "invalid message" error, which is definitely unclear what is exactly invalid in my message. I see that the code contains a check for the length of the message which is being sent, but then it maps to "Invalid message" message using i18 json files, the text of which seems too general. Moreover, searching for more codebase I found that there is another message error, which specifies information about message length.
So my proposal is to rename model.post.is_valid.msg.app_error error to something like model.post.is_valid.message_length.app_error and the mapping message to Post Message property is longer than the maximum permitted length.
Summary
When I'm trying to post a message which contains mattermost.PostMessageMaxRunesV2 + 1 of symbols, I receive
"invalid message"
error, which is definitely unclear what is exactly invalid in my message. I see that the code contains a check for the length of the message which is being sent, but then it maps to"Invalid message"
message using i18 json files, the text of which seems too general. Moreover, searching for more codebase I found that there is another message error, which specifies information about message length.So my proposal is to rename
model.post.is_valid.msg.app_error
error to something likemodel.post.is_valid.message_length.app_error
and the mapping message toPost Message property is longer than the maximum permitted length.
Steps to reproduce
Expected behavior
Observed behavior (that appears unintentional)
Possible fixes
model.post.is_valid.msg.app_error
tomodel.post.is_valid.message_length.app_error
Invalid message
mapping error text toPost Message property is longer than the maximum permitted length.
WDYT? I can create a PR by my own to solve this issue.
The text was updated successfully, but these errors were encountered: