bug: Aliyun SMS Connector incorrectly identifies a Hong Kong mobile phone number as a mainland Chinese mobile phone number

[codehz]

Describe the bug

Aliyun SMS Connector incorrectly identifies a Hong Kong mobile phone number as a mainland Chinese mobile phone number

Expected behavior

send message to HK mobile successfully

How to reproduce?

generate a dummy 852 phone number, like 85268326366
try to register with this number

Context

• Logto Cloud
• Self-hosted, Logto version =
  • Container (Docker image)
  • Raw Node.js

Screenshots

I think the problem is

logto/packages/connectors/connector-aliyun-sms/src/index.ts

Line 23 in 76fd33b

const isChinaNumber = (to: string) => /^(\+86|0086|86)?\d{11}$/.test(to);

HK number is exactly 11 digits...

[xiaoyijun]

Hi @codehz thanks for your report, this is a known issue, and we're exploring a appropriate solution. Will keep you posted.

[codehz]

Hi @codehz thanks for your report, this is a known issue, and we're exploring a appropriate solution. Will keep you posted.

Considering that the current mobile phone numbers obtained in the system all contain country code, I think we can directly use the prefix 86 to determine whether it is a Chinese mobile phone number. (aka use /^86\d{11}$/)