Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scheduler] Use allNodes when calculating nextStartNodeIndex #124933

Merged
merged 2 commits into from
May 21, 2024
Merged

[Scheduler] Use allNodes when calculating nextStartNodeIndex #124933

merged 2 commits into from
May 21, 2024

Conversation

AxeZhan
Copy link
Member

@AxeZhan AxeZhan commented May 17, 2024 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #124930

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed a bug in the scheduler where it would crash when prefilter returns a non-existent node.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 17, 2024
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 17, 2024
@AxeZhan
Copy link
Member Author

AxeZhan commented May 17, 2024

/cc @alculquicondor

@alculquicondor
Copy link
Member

Please add a release note

alculquicondor
alculquicondor reviewed May 17, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add an integration test using nodeAffinity, as reported in the issue.

Huang-Wei
Huang-Wei reviewed May 17, 2024
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks @AxeZhan !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22c877b53f7130df6d99d567d7fa47cb9e506d3d

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@Huang-Wei
Copy link
Member

/retest

@Huang-Wei
Copy link
Member

/hold for @alculquicondor to take a final look for integration test.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AxeZhan, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AxeZhan
Copy link
Member Author

AxeZhan commented May 17, 2024

ping @alculquicondor

@AxeZhan
Copy link
Member Author

AxeZhan commented May 20, 2024 •
edited

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 20, 2024
@AxeZhan
Copy link
Member Author

AxeZhan commented May 20, 2024

/kind regression

@k8s-ci-robot k8s-ci-robot added the kind/regression Categorizes issue or PR as related to a regression from a prior release. label May 20, 2024
@mikkeloscar mikkeloscar mentioned this pull request May 21, 2024
Merged
@AxeZhan AxeZhan mentioned this pull request May 21, 2024
Closed
@mikkeloscar
Copy link
Contributor

I can confirm that kube-scheduler v1.30.1 with this patch applied no longer crashes.

alculquicondor
alculquicondor reviewed May 21, 2024
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7fe92a013c35cd69d90af4be353e948c20cd66fb

@alculquicondor
Copy link
Member

Please prepare cherry-picks to all supported versions

@k8s-ci-robot k8s-ci-robot merged commit 0f584a9 into kubernetes:master May 21, 2024
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 21, 2024
This was referenced May 22, 2024
Merged
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 23, 2024
@k8s-ci-robot
Merge pull request #125039 from AxeZhan/automated-cherry-pick-of-#124…
be4afb9 
…933-upstream-release-1.30

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
k8s-ci-robot added a commit that referenced this pull request May 23, 2024
@k8s-ci-robot
Merge pull request #125043 from AxeZhan/automated-cherry-pick-of-#124…
594c39c 
…933-upstream-release-1.27

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
k8s-ci-robot added a commit that referenced this pull request May 23, 2024
@k8s-ci-robot
Merge pull request #125041 from AxeZhan/automated-cherry-pick-of-#124…
8096e38 
…933-upstream-release-1.29

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
k8s-ci-robot added a commit that referenced this pull request May 23, 2024
@k8s-ci-robot
Merge pull request #125042 from AxeZhan/automated-cherry-pick-of-#124…
1fbc482 
…933-upstream-release-1.28

Automated cherry pick of #124933: base on allNodes when calculating nextStartNodeIndex
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@denkensk denkensk Awaiting requested review from denkensk

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

Assignees

@alculquicondor alculquicondor

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

v1.30: kube-scheduler crashes with: Observed a panic: "integer divide by zero"
5 participants
@AxeZhan @k8s-ci-robot @alculquicondor @Huang-Wei @mikkeloscar