Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize ephemeral container statuses #124901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

normalize ephemeral container statuses #124901

wants to merge 2 commits into from

Conversation

zhifei92
Copy link

What type of PR is this?

/kind bug
/sig node

What this PR does / why we need it:

When a pod contains ephemeral containers , status manager don't to normalize ephemeral container statuses, leading to kubelet invoking the apiserver every 10 seconds in an attempt to complete the state synchronization, yet the status remains unsynchronized indefinitely.

When a pod contains ephemeral containers, the status manager does not normalize their statuses, causing the kubelet to repeatedly query the apiserver every 10 seconds in an attempt to synchronize the state. However, this effort is futile.

Which issue(s) this PR fixes:

Fixes #124873

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @zhifei92. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhifei92
Copy link
Author

/cc @hshiina

@k8s-ci-robot
Copy link
Contributor

@zhifei92: GitHub didn't allow me to request PR reviews from the following users: hshiina.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hshiina

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhifei92
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ffromani
Copy link
Contributor

/ok-to-test
/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 16, 2024
@ffromani
Copy link
Contributor

do we need an explicit release note? I tend to believe we do not

@ffromani
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 16, 2024
HirazawaUi
HirazawaUi reviewed May 16, 2024
View reviewed changes
pkg/kubelet/status/status_manager.go Outdated
kubetypes.SortInitContainerStatuses(pod, status.InitContainerStatuses)

// update ephtemeral container statuses
for i := range status.EphemeralContainerStatuses {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use one function to handle InitContainerStatuses EphemeralContainerStatuses and ContainerStatuses so that we can avoid duplication of code.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, thx~

@HirazawaUi
Copy link
Contributor

It may be helpful for us to add the usecase of EphemeralContainerStatuses in TestStatusEquality.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 16, 2024
@zhifei92 zhifei92 force-pushed the normalize-ephemeral-container-status branch from 1440f3e to fbd5cc0 Compare May 16, 2024 14:43
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels May 16, 2024
@zhifei92
Copy link
Author

/retest

@bart0sh bart0sh added this to Triage in SIG Node PR Triage May 20, 2024
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HirazawaUi HirazawaUi HirazawaUi left review comments

@dims dims Awaiting requested review from dims

@ffromani ffromani Awaiting requested review from ffromani

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Status: Needs Reviewer
SIG Node PR Triage
Needs Reviewer
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status manager does not normalize ephemeral container statuses
4 participants
@zhifei92 @k8s-ci-robot @ffromani @HirazawaUi