Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ref count should have an option flag #464

Open
jwu910 opened this issue Nov 27, 2019 · 4 comments
Open

Ref count should have an option flag #464

jwu910 opened this issue Nov 27, 2019 · 4 comments
Labels
enhancement New feature or request pinned Pinned issue

Comments

@jwu910
Copy link
Owner

jwu910 commented Nov 27, 2019

With the release of 3.x, Check It Out should implement an option for the --count option flag that gets passed into the git ref command that populates the list of references. This was originally limited to 500 for performance reasons.

We can keep the 500 as the default, but now that a user can search and filter, we may want to provide the ability to set no-limit/get all branch references.

https://github.com/jwu910/check-it-out/blob/master/src/utils/git.js#L185

I suggest we consider parsing the options at app start and adding the count to a global config object.

@jwu910 jwu910 added enhancement New feature or request pinned Pinned issue labels Nov 27, 2019
@bhngupta
Copy link

bhngupta commented Dec 5, 2019

I'm willing to work on this issue

@jwu910
Copy link
Owner Author

jwu910 commented Dec 5, 2019

Thanks for the interest! Please let me know if you have any questions

@mahendraHegde
Copy link

@jwu910 if no one is working on this I'd like to work on it.

@jwu910
Copy link
Owner Author

jwu910 commented Feb 17, 2020

@mahendraHegde Feel free to tackle this. Let me know if you have questions.

I think we'll want a flag option that can take an integer that will be consumed by the ref count flag. I don't remember exactly where it is in the source code right now, but we should be able to set a default value if none is set in the configstore object.

If we can figure out how to let the user set up a configstore object, but also have a forced override when calling CIO, maybe that would be ideal. If that takes too long, we can set that up on another ticket.

Let me know if you have any questions

mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Feb 21, 2020
refcount optional flag added

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Feb 21, 2020
refcount optional flag added

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Feb 21, 2020
refcount optional flag added

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Mar 11, 2020
refCount should only be valid for current execution

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Mar 12, 2020
refCount should only be valid for current execution

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde pushed a commit to mahendraHegde/check-it-out that referenced this issue Mar 13, 2020
refCount should only be valid for current execution

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde added a commit to mahendraHegde/check-it-out that referenced this issue Mar 21, 2020
refcount optional flag added

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
mahendraHegde added a commit to mahendraHegde/check-it-out that referenced this issue Mar 21, 2020
refCount should only be valid for current execution

BREAKING CHANGE: 🧨 No

✅ Closes: jwu910#464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned Pinned issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants