Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Update AnalyticsPool to hold variables for tenant ID #4521

Open
lsampras opened this issue May 2, 2024 · 6 comments · May be fixed by #4594
Open

[REFACTOR] Update AnalyticsPool to hold variables for tenant ID #4521

lsampras opened this issue May 2, 2024 · 6 comments · May be fixed by #4594
Assignees
@RaghavRox
Labels
A-Analytics good first issue Good for newcomers

Comments

@lsampras
Copy link
Member

lsampras commented May 2, 2024

Update the AnalyticsProvider (or AnalyticsConfig) to hold a variable for tenant-ID.

This can be achieved by simply adding a new field in the underlying structs for SqlxClient & ClickhouseClient.
Update the AnalyticsPool constructor method to accept a Tenant-ID.

Tenant-ID can be a new type field backed by a string;

pub struct TenantID(String);

For now the AnalyticsPool can be initialized with a fixed tenantID "default"
@Mohamed-Ayaan358
Copy link

@lsampras are all the analytic issues open for outside collaborators?

@lsampras
Copy link
Member Author

lsampras commented May 3, 2024 •
edited

All the issues are open for outside collaborators ideally (atleast for analytics),
We add good-first-issue for relatively simpler issues...

Once you ask to be assigned on an issue (could be a good-first-issue or not) the author can decide on it (there can be dependency on other issues or pending discussion or other conditions)

@SanchithHegde correct me here in case we do have a specific label or convention...

@RaghavRox
Copy link

I would like to work on this.

@subhajit20 subhajit20 mentioned this issue May 8, 2024
Open
14 tasks
@subhajit20
Copy link
Contributor

hey @lsampras can I get assigned for this issue.

@RaghavRox RaghavRox linked a pull request May 8, 2024 that will close this issue
Open
14 tasks
@lsampras
Copy link
Member Author

lsampras commented May 8, 2024

I'll assign this issue to @RaghavRox if he is still interested since we try to follow first come, first serve when assigning issues.

Sry for the confusion @subhajit20 you can pick this up if @RaghavRox is no longer interested or can take a look at one of the below issues

  1. [Feature] Add tenant-ID as a field to all KafkaStore events #4595
  2. [FEATURE] Adding Audit events for payment core operations #4525

@subhajit20
Copy link
Contributor

I'll assign this issue to @RaghavRox if he is still interested since we try to follow first come, first serve when assigning issues.

Sry for the confusion @subhajit20 you can pick this up if @RaghavRox is no longer interested or can take a look at one of the below issues

  1. [Feature] Add tenant-ID as a field to all KafkaStore events #4595
  2. [FEATURE] Adding Audit events for payment core operations #4525

Allright!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaghavRox RaghavRox

Labels
A-Analytics good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(analytics): Adds tenant ID to Analytics Provider RaghavRox/hyperswitch
4 participants
@lsampras @RaghavRox @Mohamed-Ayaan358 @subhajit20