Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove Ctx generic from payments core #4574

Merged
merged 2 commits into from May 14, 2024
Merged

refactor: remove Ctx generic from payments core #4574

merged 2 commits into from May 14, 2024

Conversation

Chethan-rao
Copy link
Contributor

@Chethan-rao Chethan-rao commented May 7, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR removes the Ctx generic being used in payments core as this is not required anymore.
This PR also fixes the failing typos CI check

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

As this PR just removes the Ctx generic, basic sanity testing should suffice

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@Chethan-rao Chethan-rao added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels May 7, 2024
@Chethan-rao Chethan-rao added this to the May 2024 Release milestone May 7, 2024
@Chethan-rao Chethan-rao requested a review from vspecky May 7, 2024 15:41
@Chethan-rao Chethan-rao self-assigned this May 7, 2024
@Chethan-rao Chethan-rao requested review from a team as code owners May 7, 2024 15:41
@Chethan-rao Chethan-rao linked an issue May 7, 2024 that may be closed by this pull request
[REFACTOR] remove Ctx generic from payments core #4573
Closed
@Chethan-rao Chethan-rao requested review from a team as code owners May 7, 2024 15:50
@likhinbopanna likhinbopanna added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 6b509c7 May 14, 2024
16 of 18 checks passed
@likhinbopanna likhinbopanna deleted the remove-ctx-generic branch May 14, 2024 13:02
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@vspecky vspecky vspecky approved these changes

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

Assignees

@Chethan-rao Chethan-rao

Labels
C-refactor Category: Refactor
Projects
None yet
Milestone
May 2024 Release
Development

Successfully merging this pull request may close these issues.

[REFACTOR] remove Ctx generic from payments core
5 participants
@Chethan-rao @SanchithHegde @vspecky @Narayanbhat166 @likhinbopanna