feat(core): Move RouterData to crate hyperswitch_domain_models #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepanshu-iiitu
added
A-core
2 tasks
|
|
||
| #[derive(Debug, Clone, serde::Deserialize)] | ||
| pub enum PaymentMethodToken { | ||
| Token(String), |
There was a problem hiding this comment.
We can consider making this a Secret<String>.
Suggested change
| Token(String), | |
| Token(Secret<String>), |
And make corresponding changes for the usages.
| code: "HE_00".to_string(), | ||
| message: "Something went wrong".to_string(), | ||
| reason: None, | ||
| status_code: 500, |
There was a problem hiding this comment.
Suggested change
| status_code: 500, | |
| status_code: http::StatusCode::INTERNAL_SERVER_ERROR.as_u16(), |
2 tasks
SanchithHegde
approved these changes
May 14, 2024
SamraatBansal
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
RouterData moved to crate
hyperswitch_domain_models.Additional Changes
Motivation and Context
#4514
#4523
How did you test it?
Basic testing is required for all the production connectors(and payment methods) on sandbox.
Checklist
cargo +nightly fmt --allcargo clippy