ci(cypress): Add bank redirect cypress test cases #4507
Conversation
tsdk02
added
A-CI-CD
| before("seed global state", () => { | ||
|
|
||
| cy.task('getGlobalState').then((state) => { | ||
| globalState = new State(state); | ||
| console.log("seeding globalState -> " + JSON.stringify(globalState)); | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Could you format the file?
|
|
||
| it("confirm-call-test", () => { | ||
| let det = getConnectorDetails(globalState.get("connectorId"))["BankRedirect"]["3DS"]["ideal"]; | ||
| cy.task('cli_log', "GLOBAL STATE -> " + JSON.stringify(globalState.data)); |
There was a problem hiding this comment.
Please remove the logs if it is not necessary
|
|
||
| it("confirm-call-test", () => { | ||
| let det = getConnectorDetails(globalState.get("connectorId"))["BankRedirect"]["3DS"]["giropay"]; | ||
| cy.task('cli_log', "GLOBAL STATE -> " + JSON.stringify(globalState.data)); |
| "billing_name": "John Doe" | ||
| }, | ||
| "bank_name": "ing", | ||
| "preferred_language": "en", |
There was a problem hiding this comment.
why did we add preferred language field in all the payment method data? this field is only in sofort pm ryt?
| "billing_details": { | ||
| "billing_name": "John Doe" | ||
| }, | ||
| "bank_name": "ing", |
There was a problem hiding this comment.
these two fields are in giropay pm data - bank_account_bic, bank_account_iban, why is this not added?
if trustpay doesn't require this, please pass it as none
| "billing_details": { | ||
| "billing_name": "John Doe" | ||
| }, | ||
| "bank_name": "hypo_noe_lb_fur_niederosterreich_u_wien", |
There was a problem hiding this comment.
bank_name is not present in sofort pm data. why is this been introduced?
| "billing_name": "John Doe" | ||
| }, | ||
| "bank_name": "hypo_noe_lb_fur_niederosterreich_u_wien", | ||
| "preferred_language": "en", |
There was a problem hiding this comment.
Could you check with bank redirect pm data, and give appropriate fields , and please remove unnecessary ones
| @@ -27,7 +27,7 @@ | |||
| "address": { | |||
| "state": "New York", | |||
| "city": "New York", | |||
| "country": "US", | |||
| "country": "NL", | |||
There was a problem hiding this comment.
why do we need this change? ig this country has been used by the card pm test cases. please revert this
Type of Change
Description
Added test scenarios for Bank Redirect method for Trustpay for the following payment methods:
Additional Changes
Motivation and Context
To increase coverage of testing for Bank Redirect Methods for various connectors.
How did you test it?
Wrote Cypress test scenarios for paymentIntent creation, paymentConfirmation, and handleRedirection for the above mentioned bank redirect payment methods for Trustpay.
Checklist
cargo +nightly fmt --allcargo clippy