Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright updates and checks #663

Open
mikeskydev opened this issue Mar 25, 2024 · 3 comments
Open

Copyright updates and checks #663

mikeskydev opened this issue Mar 25, 2024 · 3 comments
Labels
maintenance Upgrades etc.

Comments

@mikeskydev
Copy link
Member

mikeskydev commented Mar 25, 2024

When we've added new .cs files to the repository, we've included the Apache 2.0 licence notice and assigned copyright to "The Open Brush Authors". However, we haven't been adding it to files we've modified from the original codebase. Ideally we should also add "Copyright X-2024 The Open Brush Authors"

Can we automate this?

I'd like to do this at the same time as the asset database refresh, so we can add the hash to the ignore-revs

@mikeskydev mikeskydev added the maintenance Upgrades etc. label Mar 25, 2024
@mikeage
Copy link
Member

mikeage commented Mar 25, 2024

We absolutely can automate it, but we need a slightly clearer requirement.

Is this it:
Any file that doesn't contain a line matching // Copyright ... The Open Brush Authors gets a new line, below the Copyright ... Tilt Brush, with the date in the form <file first modified> - 2024
Any file that does contain a line with Copyright XXXX The Open Brush Authors gets that format changed to XXXX-2024
Any file that contains a line Copyright XXXX-202[^4] is changed to XXXX-2024

@mikeskydev
Copy link
Member Author

I think so. Perhaps doing first year modified - most recent year modified makes maintenence easier, otherwise we're setting a precedent that we should update all touched files every time the new year rolls over, rather than just being a bit more careful in PRs.

@mikeage
Copy link
Member

mikeage commented Mar 25, 2024

There's got to be some bot or action that checks for this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Upgrades etc.
Projects
None yet
Development

No branches or pull requests

2 participants