Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors on Ubuntu 22.04.1 #1306

Open
rancidponcho opened this issue Feb 4, 2023 · 3 comments
Open

Build errors on Ubuntu 22.04.1 #1306

rancidponcho opened this issue Feb 4, 2023 · 3 comments

Comments

@rancidponcho
Copy link

rancidponcho commented Feb 4, 2023

Ninja fails to build. Here's the output:
log.txt

I've tried adding cmake flags to compile with c++14, as recommended by the solution here: https://github.com/google/googletest/issues/3934

It didn't work, so I checked out 'known-good' and got everything built and all tests passed. Still wondering why 'main' won't build, but it's easy to assume that googletest's compilation was faulty because the initial error ninja throws matches the issue linked above. So I grepped for "set(CMAKE_CXX_STANDARD" and found found a bunch of directives to compile with c++11, and none for c++14. Maybe, googletest must be compiled using c++14, or maybe I have a fundamental misunderstanding of building these tools (is the 'known-good' used more often than 'main'?). I still use make, so all these cmake lists and dependencies look like witchcraft.

@ericwomer
Copy link

Just add this

-DSPIRV_SKIP_TESTS=ON -DSHADERC_SKIP_TESTS=ON

to your cmake command line arguments for now until someone can figure this out.

@rancidponcho
Copy link
Author

-DSPIRV_SKIP_TESTS=ON -DSHADERC_SKIP_TESTS=ON

Works great, thanks!

@dj2
Copy link
Contributor

dj2 commented Feb 6, 2023

I think we should leave this open until the build is fixed.

@dj2 dj2 reopened this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants