{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23096959,"defaultBranch":"master","name":"go","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-08-19T04:33:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717524689.0","currentOid":""},"activityList":{"items":[{"before":"4b8f80707f315a8f7611da4f977892bbb8d49582","after":"b788e91badd523e5bb0fc8d50cd76b8ae04ffb20","ref":"refs/heads/master","pushedAt":"2024-06-11T18:09:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: always return syscall.ECHILD from Wait for done process\n\nFor processes that don't exist at lookup time, CL 570036 and CL 588675\nmake Wait return unconditionally return ErrProcessDone when using pidfd,\nrather than attempting to make a wait system call.\n\nThis is consistent with Signal/Kill, but inconsistent with the previous\nbehavior of Wait, which would pass through the kernel error,\nsyscall.ECHILD.\n\nSwitch the ErrProcessDone case to return syscall.ECHILD instead for\nconsistency with previous behavior.\n\nThat said, I do think a future release should consider changing ECHILD\nto ErrProcessDone in all cases (including when making an actual wait\nsystem call) for better consistency with Signal/Kill/FindProcess.\n\nFixes #67926.\n\nCq-Include-Trybots: luci.golang.try:gotip-darwin-amd64_14,gotip-solaris-amd64,gotip-openbsd-amd64\nChange-Id: I1f688a5751d0f3aecea99c3a5b35c7894cfc2beb\nReviewed-on: https://go-review.googlesource.com/c/go/+/591816\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Kirill Kolyshkin \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"os: always return syscall.ECHILD from Wait for done process"}},{"before":"04b5d1325602cab8359db6dfe029a9c2162ba9ea","after":"4b8f80707f315a8f7611da4f977892bbb8d49582","ref":"refs/heads/master","pushedAt":"2024-06-11T17:26:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"crypto/tls: improve error log produced during TestBogoSuite\n\nThe existing implementation logs some errors to the results file created in TestBogoSuite.\nThis change would additionally log json errors to the results file.\n\nChange-Id: Ib1a6f612ed83f6c5046531ee259c4e85dd71402a\nReviewed-on: https://go-review.googlesource.com/c/go/+/591379\nReviewed-by: Filippo Valsorda \nAuto-Submit: Filippo Valsorda \nReviewed-by: Roland Shoemaker \nReviewed-by: Michael Pratt \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"crypto/tls: improve error log produced during TestBogoSuite"}},{"before":"35d721b0cb3da3f464af26fb8503a521cf9901ff","after":"04b5d1325602cab8359db6dfe029a9c2162ba9ea","ref":"refs/heads/master","pushedAt":"2024-06-11T17:19:19.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/next: document GORISCV64 environment variable\n\nFor #65614.\nUpdates #61476.\n\nChange-Id: Id677aa6d2a59366ab75a26f08a383d2d253f270e\nReviewed-on: https://go-review.googlesource.com/c/go/+/591895\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Joel Sing \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"doc/next: document GORISCV64 environment variable"}},{"before":"b3a57e43c7517491c6220b637f70918fa7ca6e20","after":"35d721b0cb3da3f464af26fb8503a521cf9901ff","ref":"refs/heads/master","pushedAt":"2024-06-11T17:11:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"time: correct spelling, queing -> queuing\n\nChange-Id: I418953a766db22b134a9569161f06cf8682c1eef\nReviewed-on: https://go-review.googlesource.com/c/go/+/591336\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Pratt \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"time: correct spelling, queing -> queuing"}},{"before":"aed1f925f24d4ad6ff2f2d77c04e4c5b72fdb49f","after":"b3a57e43c7517491c6220b637f70918fa7ca6e20","ref":"refs/heads/master","pushedAt":"2024-06-11T17:09:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"time: add to format documentation about dangers of using RFC1123{,Z} for parsing\n\nWhen using time.RFC1123Z to parse the date header value out of an email,\nan error is returned for dates that occur in the first 9 days of a\nmonth. This is because the format strings for RFC 1123 defined in the\ntime package indicate that the day should be prefixed with a leading 0.\n\nReading the spec, the line that talks about it seems to indicate that\ndays can be either 1 or 2 digits:\n\n `date = 1*2DIGIT month 2*4DIGIT`\n\nSo a date header with a day like `7` with no leading zero should be\naccepted.\n\nFixes #67887\n\nChange-Id: Ie7ee40d94da2c8c0417957e8b89f9987314949c8\nGitHub-Last-Rev: 22a5a52fcb7ee25e5005bb9a014ef8a94d52fb32\nGitHub-Pull-Request: golang/go#67888\nReviewed-on: https://go-review.googlesource.com/c/go/+/591335\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Pratt \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"time: add to format documentation about dangers of using RFC1123{,Z} …"}},{"before":"5d850046222b52dd79c5b9cb3d63449aa126c988","after":"aed1f925f24d4ad6ff2f2d77c04e4c5b72fdb49f","ref":"refs/heads/master","pushedAt":"2024-06-11T17:08:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os/user: make Lookup* functions properly handle ENOENT\n\nThe libc docs say that these functions can return ENOENT, and\nper issue #67912, this does happen in practice sometimes. Handle\nboth the ENOENT and !found cases the same way, for Lookup,\nLookupId, LookupGroup, LookupGroupId.\n\nFixes #67912\n\nChange-Id: I993935af44c83ad785b6cd735fc313a3647daa19\nReviewed-on: https://go-review.googlesource.com/c/go/+/591555\nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Pratt ","shortMessageHtmlLink":"os/user: make Lookup* functions properly handle ENOENT"}},{"before":"5d759ac902925011e3266d318751686e47c6fe5b","after":"5d850046222b52dd79c5b9cb3d63449aa126c988","ref":"refs/heads/master","pushedAt":"2024-06-11T16:54:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: update link to RISC-V profile doc\n\nThe URL has changed.\n\nChange-Id: I295020c59aaf64a89c4307fca527163095148a67\nReviewed-on: https://go-review.googlesource.com/c/go/+/591897\nReviewed-by: Joel Sing \nReviewed-by: M Zhuo \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Mark Ryan ","shortMessageHtmlLink":"cmd/go: update link to RISC-V profile doc"}},{"before":"0d478d8e07f9667d7c32ea5bb10647dd14725829","after":"5d759ac902925011e3266d318751686e47c6fe5b","ref":"refs/heads/master","pushedAt":"2024-06-11T16:48:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"doc/next: reword linker -bindnow release notes\n\nFor #65614.\n\nChange-Id: I1a2a4bc18601526053840a280e0604a8e1028ce6\nReviewed-on: https://go-review.googlesource.com/c/go/+/591899\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"doc/next: reword linker -bindnow release notes"}},{"before":"beaf7f3282c2548267d3c894417cc4ecacc5d575","after":"0d478d8e07f9667d7c32ea5bb10647dd14725829","ref":"refs/heads/master","pushedAt":"2024-06-11T16:25:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/types, types2: add missing Unalias calls in type unifier\n\nThe unification code has \"early exits\" when the compared\ntypes are pointer-identical.\n\nBecause of Alias nodes, we cannot simply compare x == y but we\nmust compare Unalias(x) == Unalias(y). Still, in the common case\nthere are no aliases, so as a minor optimization we write:\n\n x == y || Unalias(x) == Unalias(y)\n\nto test whether x and y are (pointer-) identical.\nAdd the missing Unalias calls in the place where we forgot them.\n\nFixes #67872.\n\nChange-Id: Ia26ffe7205b0417fc698287a4aeb1c900d30cc0d\nReviewed-on: https://go-review.googlesource.com/c/go/+/591975\nReviewed-by: Robert Findley \nAuto-Submit: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Griesemer ","shortMessageHtmlLink":"go/types, types2: add missing Unalias calls in type unifier"}},{"before":"a130fb63091bf3103bb7baabbd2484f7e560edae","after":"beaf7f3282c2548267d3c894417cc4ecacc5d575","ref":"refs/heads/master","pushedAt":"2024-06-10T22:07:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os: overhaul handling of PID vs pidfd within Process\n\nThere are several issues with pidfd handling today:\n\n* The zero value of a Process makes the handle field appear valid, so\n methods attempt to use it as a pidfd rather than falling back to the\n PID as they should (#67634).\n\n* If a process doesn't exist, FindProcess returns a Process with Pid ==\n -2, which is not a compatible change (#67640).\n\n* pidfd close is racy as-is. A Release call or successful Wait will\n clear the handle field and close the pidfd. However, a concurrent call\n may have already loaded the handle field and could then proceed to use\n the closed FD (which could have been reopened as a different pidfd,\n targeting a different process) (#67641).\n\nThis CL performs multiple structural changes to the internals of\nProcess.\n\nFirst and foremost, each method is refactored to clearly select either\npidfd or raw pid mode. Previously, raw pid mode was structured as a\nfallback when pidfd mode is unavailable. This works fine, but it does\nnot make it clear that a given Process object either always uses pidfd\nor always uses raw pid. Since each mode needs to handle different race\nconditions, it helps to make it clear that we can't switch between modes\nwithin a single Process object.\n\nSecond, pidfd close safety is handled by reference counting uses of the\nFD. The last user of the FD will close the FD. For example, this means\nthat with concurrent Release and Signal, the Signal call may be the one\nto close the FD. This is the bulk of this CL, though I find the end\nresult makes the overall implementation easier to reason about.\n\nThird, the PID path handles a similar race condtion between Wait and\nKill: Wait frees the PID value in the kernel, which could be reallocated\ncausing Kill to target the wrong process. This is handled with a done\nflag and a mutex. The done flag now shares the same state field used for\nthe handle.\n\nSimilarly, the Windows implementation reuses all of the handle reference\ncounting that Linux uses. This means the implementations more\nconsistent, and make Windows safe against the same handle reuse\nproblems. (Though I am unsure if Windows ever reuses handles).\n\nWait has a slight behavior change on Windows: previously Wait after\nRelease or an earlier Wait would hang indefinitely (WaitForSingleObject\non syscall.InvalidHandle waits indefinitely). Now it returns the same\nerrors as Linux (EINVAL and ErrProcessDone, respectively).\n\nSimilarly, Release on Windows no longer returns close errors, as it may\nnot actually be the place where the close occurs.\n\nFixes #67634.\nFixes #67640.\nFixes #67641.\nUpdates #67642.\n\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest\nChange-Id: I2ad998f7b67d32031e6f870e8533dbd55d3c3d10\nReviewed-on: https://go-review.googlesource.com/c/go/+/588675\nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"os: overhaul handling of PID vs pidfd within Process"}},{"before":"4256ec16616827b8ef5a19f74599aa44ffe6111a","after":"a130fb63091bf3103bb7baabbd2484f7e560edae","ref":"refs/heads/master","pushedAt":"2024-06-10T19:45:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile/internal/ssa: fix DWARF location expr for .closureptr\n\nCL 586975 added support to the compiler back end to emit a synthetic\n\".closureptr\" variable in range func bodies, plus code to spill the\nincoming context pointer to that variable's location on the stack.\n\nThis patch fixes up the code in the back end that generates DWARF\nlocation lists for incoming parameters (which sometimes arrive in\nregisters) in the \"-l -N\" no-optimization case to also create a\ncorrect DWARF location list for \".closureptr\", a two-piece list\nreflecting the fact that its value arrives in a register and then is\nspilled to the stack in the prolog.\n\nFixes #67918.\n\nChange-Id: I029305b5248b8140253fdeb6821b877916fbb87a\nReviewed-on: https://go-review.googlesource.com/c/go/+/591595\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alessandro Arzilli \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"cmd/compile/internal/ssa: fix DWARF location expr for .closureptr"}},{"before":"f515c1bac708c46f3bb4811439fc75bd013300c9","after":"4256ec16616827b8ef5a19f74599aa44ffe6111a","ref":"refs/heads/master","pushedAt":"2024-06-10T17:49:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile/internal/syntax: return correct start pos for KeyValueExprs\n\nFixes #67866.\n\nChange-Id: Id9d345aab87e493b8ed94319c5acaa1900362648\nReviewed-on: https://go-review.googlesource.com/c/go/+/591695\nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/compile/internal/syntax: return correct start pos for KeyValueExprs"}},{"before":"da65071f36d6d64881df177a9a9d5f3fc2daade7","after":"f515c1bac708c46f3bb4811439fc75bd013300c9","ref":"refs/heads/master","pushedAt":"2024-06-10T14:47:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/work: avoid panic for a repeated //go:debug setting\n\nThe creation of a bytes.Buffer in one code path is missing causing a nil\npointer dereference.\n\nChanged (as rec. by Bryan Mills) to use fmt.Appendf() on []byte instead of\nfmt.Fprintf on *bytes.Buffer - simpler and avoids duplicated code (but\nrequires Go 1.19 or later).\n\nAdded test to verify the change (as rec. by Michael Matloob) at\nsrc\\cmd\\go\\testdata\\script\\build_repeated_godebug_issue62346.txt\n\nFixes #62346\n\nChange-Id: Ic3267d878a6f7ebedb1cde64e6206de404176b10\nReviewed-on: https://go-review.googlesource.com/c/go/+/523836\nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Michael Matloob ","shortMessageHtmlLink":"cmd/go/internal/work: avoid panic for a repeated //go:debug setting"}},{"before":"c83b1a7013784098c2061ae7be832b2ab7241424","after":"da65071f36d6d64881df177a9a9d5f3fc2daade7","ref":"refs/heads/master","pushedAt":"2024-06-10T13:49:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile/internal/types2: fix typo in comment for StoreTypesInSyntax\n\nChange-Id: Ia73b15b6df5e6f88741f2b54258d7cbad0239ddd\nReviewed-on: https://go-review.googlesource.com/c/go/+/591396\nReviewed-by: Robert Findley \nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"cmd/compile/internal/types2: fix typo in comment for StoreTypesInSyntax"}},{"before":"532cf270590da822a0803ebd1b5d40f454007ddf","after":"c83b1a7013784098c2061ae7be832b2ab7241424","ref":"refs/heads/master","pushedAt":"2024-06-07T21:15:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"sync: include links to the Go memory model in package documentation\n\nThe lack of links to https://go.dev/ref/mem in the sync package\ndocumentation makes it difficult to read for people who have no previous\nknowledge of that page. This PR includes the links where needed.\n\nFixes #67891\n\nChange-Id: I0e1344cc6d7b702f4cb2e55fe0fcee3eb089391a\nGitHub-Last-Rev: 427cf58aaeaae2e4b060248dd592e5fe8c6b7df4\nGitHub-Pull-Request: golang/go#67892\nReviewed-on: https://go-review.googlesource.com/c/go/+/591395\nReviewed-by: Michael Knyszek \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sync: include links to the Go memory model in package documentation"}},{"before":"1634fde4f918223614fd8893db8dd7ca4ebcda01","after":"532cf270590da822a0803ebd1b5d40f454007ddf","ref":"refs/heads/master","pushedAt":"2024-06-07T20:14:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"syscall: rm go:linkname from origRlimitNofile\n\nSince CL 588076 runc can do fine without the kludge. The code accessing the symbol is now guarded with `go:build !go1.23` in all supported runc branches (main: [1], release-1.1: [2]).\n\nThis reverts part of CL 587219.\n\nUpdates #67401.\n\nFor #66797.\n\n[1]: https://github.com/opencontainers/runc/pull/4290\n[2]: https://github.com/opencontainers/runc/pull/4299\n\nChange-Id: I204843a93c36857e21ab9b43bd7aaf046e8b9787\nReviewed-on: https://go-review.googlesource.com/c/go/+/587918\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Knyszek \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"syscall: rm go:linkname from origRlimitNofile"}},{"before":"d5e5b143057921721061c3f39f14061370e4a732","after":"1634fde4f918223614fd8893db8dd7ca4ebcda01","ref":"refs/heads/master","pushedAt":"2024-06-07T19:09:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"iter: don't iterate if stop is called before next on Pull\n\nConsider the following code snippet:\n\n next, stop := iter.Pull(seq)\n stop()\n\nToday, seq will iterate exactly once before it notices that its\niteration is invalid to begin with. This effect is observable in a\nvariety of ways. For example, if the iterator panics, since that panic\nmust propagate to the caller of stop. But if the iterator is stateful in\nanyway, then it may update some state.\n\nThis is somewhat unexpected and because it's observable, can be depended\nupon. This behavior does not align well with other possible\nimplementations of Pull, like CPS performed by the compiler. It's also\njust odd to let even one iteration happen, precisely because of\nunexpected state modification.\n\nFix this by not iterating at all of the done flag is set before entering\nthe iterator.\n\nFor #67712.\n\nChange-Id: I18162e29df45a2e8968f68379450d92e1de47c4d\nReviewed-on: https://go-review.googlesource.com/c/go/+/590075\nReviewed-by: David Chase \nReviewed-by: Austin Clements \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"iter: don't iterate if stop is called before next on Pull"}},{"before":"e709992afda6a96f0a5691aaf0883e3cfbd46946","after":"d5e5b143057921721061c3f39f14061370e4a732","ref":"refs/heads/master","pushedAt":"2024-06-07T19:03:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile/ssa: fix (MOVWZreg (RLWINM)) folding on PPC64\n\nRLIWNM does not clear the upper 32 bits of the target register if\nthe mask wraps around (e.g 0xF000000F). Don't elide MOVWZreg for\nsuch masks. All other usage clears the upper 32 bits.\n\nFixes #67844.\n\nChange-Id: I11b89f1da9ae077624369bfe2bf25e9b7c9b79bc\nReviewed-on: https://go-review.googlesource.com/c/go/+/590896\nReviewed-by: Keith Randall \nReviewed-by: Cherry Mui \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/compile/ssa: fix (MOVWZreg (RLWINM)) folding on PPC64"}},{"before":"fbe478521f35ce368a6de476f373478a3d83a189","after":"e709992afda6a96f0a5691aaf0883e3cfbd46946","ref":"refs/heads/master","pushedAt":"2024-06-07T18:50:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: avoid when go.env contain GOTOOLCHAIN=local test fail\n\nThe test fail when $GOROOT/go.env contain GOTOOLCHAIN=local\nbecause GOTOOLCHAIN=local is assumed to be a non-default value.\nThis CL fixed the test failure\nby using go.env from the test as $GOROOT/go.env throughout the test.\nTest have also been added to ensure that\nwhen $GOROOT/go.env contain GOTOOLCHAIN=local,\nGOTOOLCHAIN=local is not taken as a non-default value.\n\nFixes #67793\n\nChange-Id: Ibc5057d38d36c6c55726a039de1e7c37d6935b52\nGitHub-Last-Rev: 12b62464e671021320c54e251dfb1ebcb5925096\nGitHub-Pull-Request: golang/go#67807\nReviewed-on: https://go-review.googlesource.com/c/go/+/590196\nReviewed-by: Sam Thanawalla \nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go: avoid when go.env contain GOTOOLCHAIN=local test fail"}},{"before":"ce51533a9d541fa0d1511e18f20ee61d4ecbb5a9","after":"fbe478521f35ce368a6de476f373478a3d83a189","ref":"refs/heads/master","pushedAt":"2024-06-07T18:27:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go: add pointer to build flags in \"go get\" docs\n\nFixes #67728\n\nChange-Id: Ifbdee77dcebd865eac9501ec4615128eb3a9c9c0\nReviewed-on: https://go-review.googlesource.com/c/go/+/590797\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Matloob \nCommit-Queue: Ian Lance Taylor ","shortMessageHtmlLink":"cmd/go: add pointer to build flags in \"go get\" docs"}},{"before":"640067f28a95bbc32aa701ceea204e28e510b04f","after":"ce51533a9d541fa0d1511e18f20ee61d4ecbb5a9","ref":"refs/heads/master","pushedAt":"2024-06-07T18:12:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"os/signal: remove SIGSYS from list of signals that take no action\n\nIt actually causes the program to throw.\n\nFixes #67729\n\nChange-Id: Id970baff631616a4dc4e434827e622e1b16f2724\nReviewed-on: https://go-review.googlesource.com/c/go/+/590915\nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Cherry Mui \nAuto-Submit: Ian Lance Taylor \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"os/signal: remove SIGSYS from list of signals that take no action"}},{"before":"0b72631a8229bcb86913f4855e217ddedbfbbb46","after":"640067f28a95bbc32aa701ceea204e28e510b04f","ref":"refs/heads/master","pushedAt":"2024-06-07T17:57:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/http: check GetConfigForClient in server.ServeTLS\n\nJust like for tls.Config.GetCertificate the http.Server.ServeTLS method\nshould be checking tls.Config.GetConfigForClient before trying top open\nthe specified certFile/keyFile.\n\nThis was previously fixed for crypto/tls when using tls.Listen in\nCL205059, but the same change for net/http was missed. I've added a\ncomment src/crypto/tls/tls.go in the relevant section in the hope that\nany future changes of a similar nature consider will consider updating\nnet/http as needed as well.\n\nChange-Id: I312303bc497d92aa2f4627fe2620c70779cbcc99\nGitHub-Last-Rev: 6ed29a900816a13690a9f3e26476d9bc1055a6f7\nGitHub-Pull-Request: golang/go#66795\nReviewed-on: https://go-review.googlesource.com/c/go/+/578396\nReviewed-by: Filippo Valsorda \nReviewed-by: Damien Neil \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"net/http: check GetConfigForClient in server.ServeTLS"}},{"before":"98529a8e7cf1cc0b561f26a4bd3ddf8f6dbd2f8a","after":"0b72631a8229bcb86913f4855e217ddedbfbbb46","ref":"refs/heads/master","pushedAt":"2024-06-07T15:22:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname\n\nCurrently, the compiler generates the argument stack map based on\nthe function signature for bodyless function declarations, if it\nis not linknamed. The assumption is that linknamed function is\nprovided by (Go code in) another package, so its args stack map\nwill be generated when compiling that package.\n\nNow we have linknames added to declarations of assembly functions,\nto signal that this function is accessed externally. Examples\ninclude runtime.morestack_noctxt, math/big.addVV. In the current\nimplementation the compiler does not generate its args stack map.\nThat causes the assembly function's args stack map missing.\nInstead, change it to generate the stack map if it is a\ndeclaration of an ABI0 function, which can only be defined in\nassembly and passed to the compiler through the -symabis flag. The\nstack map generation currently only works with ABI0 layout anyway,\nso we don't need to handle ABIInternal assembly functions.\n\nChange-Id: Ic9da3b4854c604e64ed01584da3865994f5b95b8\nReviewed-on: https://go-review.googlesource.com/c/go/+/587928\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: generate args_stackmap for ABI0 assembly func regardless…"}},{"before":"f7c330eac7777612574d8a1652fd415391f6095e","after":"98529a8e7cf1cc0b561f26a4bd3ddf8f6dbd2f8a","ref":"refs/heads/master","pushedAt":"2024-06-07T14:53:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/link: don't include deadcoded function symbols in shared build mode\n\nIn shared build mode, we include all symbols. This includes\nfunction symbols that are deadcoded by the compiler. They don't\nreally get compiled, and their metadata may be missing, causing\nlinker failures. Skip them.\n\nFixes #67635.\n\nChange-Id: Ic0e64bd032be499cca26da5e9e3ffbe9998bac05\nReviewed-on: https://go-review.googlesource.com/c/go/+/588316\nReviewed-by: Than McIntosh \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: don't include deadcoded function symbols in shared build mode"}},{"before":"cf501e05e138e6911f759a5db786e90b295499b9","after":"f7c330eac7777612574d8a1652fd415391f6095e","ref":"refs/heads/master","pushedAt":"2024-06-07T01:57:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"runtime: add a note on SetFinalizer doc about method receiver\n\nA method receiver can be collected during the execution of that method.\nThis does make sense when thinking about how the GC would work, but\nalso seems not very obvious, so a point in the docs can increase the\nchance of avoiding issues caused by missing KeepAlive of method\nreceivers.\n\nChange-Id: I6817237dd022b5729dbdcda1b9f70c7059605575\nGitHub-Last-Rev: 878bf3fde7b4ed66be0302ffdd5e704b4cd70a6c\nGitHub-Pull-Request: golang/go#67777\nReviewed-on: https://go-review.googlesource.com/c/go/+/589735\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"runtime: add a note on SetFinalizer doc about method receiver"}},{"before":"2f6ba0c294e8ab202666e34d833286eecaa26d2b","after":"cf501e05e138e6911f759a5db786e90b295499b9","ref":"refs/heads/master","pushedAt":"2024-06-06T21:59:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"net/http: send body or close connection on expect-100-continue requests\n\nWhen sending a request with an \"Expect: 100-continue\" header,\nwe must send the request body before sending any further requests\non the connection.\n\nWhen receiving a non-1xx response to an \"Expect: 100-continue\" request,\nsend the request body if the connection isn't being closed after\nprocessing the response. In other words, if either the request\nor response contains a \"Connection: close\" header, then skip sending\nthe request body (because the connection will not be used for\nfurther requests), but otherwise send it.\n\nCorrect a comment on the server-side Expect: 100-continue handling\nthat implied sending the request body is optional. It isn't.\n\nFor #67555\n\nChange-Id: Ia2f12091bee697771087f32ac347509ec5922d54\nReviewed-on: https://go-review.googlesource.com/c/go/+/591255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"net/http: send body or close connection on expect-100-continue requests"}},{"before":"4b0dd556080fc207962fabdd93007cd4c6ebb04a","after":"2f6ba0c294e8ab202666e34d833286eecaa26d2b","ref":"refs/heads/master","pushedAt":"2024-06-06T19:50:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/modget: print a fatal error if -d=false\n\nBetween Go 1.18 and Go 1.22 go get printed a fatal error if -d was\nexplicitly set to false. That behavior was reverted in CL 572176, when\nwe made the -d flag a no-op, but it would make it easier to remove the\n-d flag in the future if we continue to print a fatal error if -d is\nexplicitly set to false.\n\nThis change brings back the fatal error for -d=false while keeping the\nwarning printed for -d=true.\n\nFor #43684\n\nChange-Id: I38ae3a3619d408c0237ff485ddee4403b8188abd\nReviewed-on: https://go-review.googlesource.com/c/go/+/591135\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Sam Thanawalla ","shortMessageHtmlLink":"cmd/go/internal/modget: print a fatal error if -d=false"}},{"before":"2be4b3913a3693958f95b520a309bfc4fda0ee21","after":"4b0dd556080fc207962fabdd93007cd4c6ebb04a","ref":"refs/heads/master","pushedAt":"2024-06-06T18:36:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/modload: add line numbers to godebug errors\n\nIn addition, add a line number to the go.work error for multiple use statements\nfor the same directory. Also clean up the error prefix for go.work\nerrors now containing line numbers.\n\nFixes #67623\n\nChange-Id: Ia7edcc50f7d7ec907b4a9eb4fe270c75d04c1fa5\nReviewed-on: https://go-review.googlesource.com/c/go/+/590135\nReviewed-by: Sam Thanawalla \nAuto-Submit: Michael Matloob \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go/internal/modload: add line numbers to godebug errors"}},{"before":"1831437f197d43608c8086dc42530a89d975aba2","after":"2be4b3913a3693958f95b520a309bfc4fda0ee21","ref":"refs/heads/master","pushedAt":"2024-06-06T18:35:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"cmd/go/internal/modload: respect overlays when loading go.work files\n\nBefore this change, we didn't initialize the overlays in the fsys\npackage or use the fsys logic to read the files, so overlays were not\nrespected for go.work files. Initialize fsys before loading the go.work\nfile (initialization is idempotent) and use the new fsys.ReadFile\nfunction to read the file instead of os.ReadFile.\n\nfsys.ReadFile just opens the file with fsys.Open and then calls\nio.ReadAll on it. (This is less efficient than what os.ReadFile does:\nos.ReadFile reads into a buffer it allocated that's the file's size\nwhile io.ReadAll doesn't know how big the file is so it just reads in\n512 byte chunks.)\n\nChange-Id: Ic40bcbb483a16c5d4dd1d896306ea99a16f370f3\nReviewed-on: https://go-review.googlesource.com/c/go/+/590755\nReviewed-by: Sam Thanawalla \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Michael Matloob ","shortMessageHtmlLink":"cmd/go/internal/modload: respect overlays when loading go.work files"}},{"before":"45967bb18e04fa6dc62c2786c87ce120443c64f6","after":"1831437f197d43608c8086dc42530a89d975aba2","ref":"refs/heads/master","pushedAt":"2024-06-06T15:47:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"math/big: better doc string for Float.Copy, add example test\n\nFixes #66358.\n\nChange-Id: Ic9bde88eabfb2a446d32e1dc5ac404a51ef49f11\nReviewed-on: https://go-review.googlesource.com/c/go/+/590635\nAuto-Submit: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Robert Griesemer ","shortMessageHtmlLink":"math/big: better doc string for Float.Copy, add example test"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYodz5QA","startCursor":null,"endCursor":null}},"title":"Activity · golang/go"}