Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing ESCAPE does not cancel renaming file and folder in the editor (4.3 dev6) #91878

Closed
spiralhalo opened this issue May 12, 2024 · 2 comments

Comments

@spiralhalo
Copy link

Tested versions

  • Reproducible in: 4.3.dev6
  • Not reproducible in: 4.3.dev5, 4.2.1

System information

Godot v4.3.dev6 - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 SUPER (NVIDIA; 31.0.15.3118) - Intel(R) Core(TM) i7-8700 CPU @ 3.20GHz (12 Threads)

Issue description

Pressing ESCAPE when renaming a file should cancel it according to previous versions. Instead, the renaming takes place anyway.

Steps to reproduce

  1. Open any project in 4.3.dev6.
  2. Rename any file or folder, either by selecting and pressing F2, or right click Rename...
  3. Press ESCAPE. Should cancel but instead the rename takes place.

Minimal reproduction project (MRP)

Any

@AThousandShips
Copy link
Member

AThousandShips commented May 12, 2024

This should be solved on latest master after:

Edit: Testing on latest version this seems to be fixed indeed, so please try to replicate this on your end

@spiralhalo
Copy link
Author

Tested on recent version built with scons ( v4.3.dev.custom_build [bdc0316] ), looks fixed as far as I'm concerned.

  • Pressing ESC properly cancels renaming.
  • Confirming with ENTER doesn't show "already exist" message.

Feel free to close the issue as appropriate. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants