Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bounding box glitch after selecting different nodes #91860

Open
ryevdokimov opened this issue May 12, 2024 · 6 comments · May be fixed by #92275
Open

Bounding box glitch after selecting different nodes #91860

ryevdokimov opened this issue May 12, 2024 · 6 comments · May be fixed by #92275

Comments

@ryevdokimov
Copy link
Contributor

ryevdokimov commented May 12, 2024

Tested versions

v4.3.dev.custom_build [bdc0316] (glitch)

v4.3.dev5.official [89f70e9] (no glitch)

System information

Godot v4.3.dev (bdc0316) - Windows 10.0.22631 - Vulkan (Forward+) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.24002.92) - AMD Ryzen 7 PRO 6850U with Radeon Graphics (16 Threads)

Issue description

Note origin:

2024-05-11.20-33-08.mp4
2024-05-20.07-14-37.mp4

Steps to reproduce

Focus on origin and perform a drag-and-drop to instantiate scene or select via the SceenTree

Minimal reproduction project (MRP)

N/A

@ryevdokimov
Copy link
Contributor Author

This also happens when you select nodes via the SceenTree, but weirdly not through the viewport.

@ryevdokimov ryevdokimov changed the title Bounding box glitch after drag and drop to instantiate scene Bounding box glitch after drag and drop to instantiate scene or selection via the SceenTree May 20, 2024
@AThousandShips
Copy link
Member

Can you describe how it glitches? I don't see anything wrong in the video, though it's only very brief so hard to see anything

@ryevdokimov
Copy link
Contributor Author

The bounding box appears at the origin, here is a video of it occurring during selection via the SceenTree where it is a lot more obvious.

2024-05-20.07-14-37.mp4

@ryevdokimov ryevdokimov changed the title Bounding box glitch after drag and drop to instantiate scene or selection via the SceenTree Bounding box glitch after selecting different nodes May 20, 2024
@ryevdokimov
Copy link
Contributor Author

Yeah, I think this is technically a regression that has something to do with selecting different nodes in general. I can replicate this when instantiating, duplicating, selecting via the SceenTree. This is not an issue in 4.3dev5.

@clayjohn
Copy link
Member

Confirmed in dev6, cannot reproduce in dev5

@clayjohn
Copy link
Member

clayjohn commented May 20, 2024

Bisected to 48a6476:

48a64768616078f9a6a676e8d2ce7867702675f5 is the first bad commit
commit 48a64768616078f9a6a676e8d2ce7867702675f5
Author: ajreckof <tbonhoure@ymail.com>
Date:   Sun Apr 14 12:56:49 2024 +0200

    Fix going forward backward in editor selection history.

 editor/editor_node.cpp     | 14 +++++++++++---
 editor/multi_node_edit.cpp |  2 +-
 editor/multi_node_edit.h   | 15 ++++++++++++++-
 editor/scene_tree_dock.cpp |  7 +++++++
 editor/scene_tree_dock.h   |  1 +
 5 files changed, 34 insertions(+), 5 deletions(-)

cc @ajreckof

@ajreckof ajreckof linked a pull request May 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants