Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Fix generation of disabled_classes.gen.h after #91624 #91870

Merged
merged 1 commit into from May 13, 2024
Merged

SCons: Fix generation of disabled_classes.gen.h after #91624 #91870

merged 1 commit into from May 13, 2024
+1 −1

Conversation

scgm0
Copy link
Contributor

@scgm0 scgm0 commented May 12, 2024 •
edited by akien-mga

@scgm0 scgm0 requested a review from a team as a code owner May 12, 2024 09:58
Repiteo
Repiteo approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@Repiteo Repiteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my b

@Calinou Calinou added bug topic:buildsystem cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 12, 2024
@Calinou Calinou added this to the 4.3 milestone May 12, 2024
@akien-mga akien-mga changed the title Fix "disabled_classes.gen.h" SCons: Fix generation of disabled_classes.gen.h after #91624 May 12, 2024
@akien-mga akien-mga added regression and removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release labels May 12, 2024
@akien-mga
Copy link
Member

Amended the commit message to be clearer.

@akien-mga akien-mga merged commit 3585c2e into godotengine:master May 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@scgm0 scgm0 deleted the fix_disabled_classes branch May 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@Repiteo Repiteo Repiteo approved these changes

Assignees
No one assigned
Labels
bug regression topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Scons export template with build_profile="profile.build" throws impossibly long error message.
4 participants
@scgm0 @akien-mga @Repiteo @Calinou