Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing "AutoPlay on Load" button of the sprite frames editor emit error to the output #91826

Closed
Chaosus opened this issue May 11, 2024 · 1 comment · Fixed by #91830
Closed

Pressing "AutoPlay on Load" button of the sprite frames editor emit error to the output #91826

Chaosus opened this issue May 11, 2024 · 1 comment · Fixed by #91830
Labels
bug regression topic:animation topic:editor
Milestone
4.3

Comments

@Chaosus
Copy link
Member

Chaosus commented May 11, 2024 •
edited

Tested versions

4.3: 2ba22d1

System information

Windows 11

Issue description

sprite_frames_editor_bug

Steps to reproduce

Create and save a SpriteFrames as a separate resource, open it and check the bug.

Minimal reproduction project (MRP)

spriteframesbug.zip
@Chaosus Chaosus added this to the 4.3 milestone May 11, 2024
@Chaosus
Copy link
Member Author

Chaosus commented May 11, 2024 •
edited

A regression from #85494, if SpriteFrames is saved as a separate resource, frames.ptr() is not built-in and failed to found a correct history_id in:

godot/editor/editor_undo_redo_manager.cpp

Lines 80 to 94 in 2ba22d1

if (Resource *res = Object::cast_to<Resource>(p_object)) {
if (res->is_built_in()) {
if (res->get_path().is_empty()) {
int idx = EditorNode::get_editor_data().get_current_edited_scene_history_id();
if (idx > 0) {
history_id = idx;
}
} else {
int idx = EditorNode::get_editor_data().get_scene_history_id_from_path(res->get_path().get_slice("::", 0));
if (idx > 0) {
history_id = idx;
}
}
}
}

@Chaosus Chaosus mentioned this issue May 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression topic:animation topic:editor
Projects
None yet
Milestone
4.3
Development

Successfully merging a pull request may close this issue.

Fix errors on pressing autoplay in sprite frames editor Chaosus/godot
1 participant
@Chaosus