New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main editor toolbar icons are blurry #88165
Comments
Non-integer spacing somewhere? There has been a complete refactoring of the editor theme generation with emphasis on margins/spacings. Could this be a side effect? |
A quick comparison of versions: My guess is that it's related to SVG_Renderer from Freetype (this file, maybe? I'm not a C developer. Maybe @bruvzg could help us confirm this bug is related to Freetype update. By the way, sorry for bothering you (tagging). |
No, FreeType is not related to the icons in any way. Most likely it's something with icon positions (theme or control changes). |
Interesting find! Then we should look for drawing code that puts images at non-integer coordinates. This is a probable culprit. UI toolkits of long ago may have had logic that automatically snap images and primitives to the nearest pixel. In Godot, if you draw something between pixels, it gets blurry. Rounding coords to the closest pixel after calculation may be a solution. One suggestion would be to recommend checking the result on non-hidpi displays every time there is UI code being worked on. Perhaps add a little mention in the developer docs about that? Because someone who only works on 4K/Retina/hidpi or similar screens would never see the issue on his configuration. |
Tested versions
System information
Godot v4.3.dev3 - Ubuntu 22.04.3 LTS 22.04 - X11 - Vulkan (Mobile) - integrated Intel(R) Iris(R) Plus Graphics (ICL GT2) () - Intel(R) Core(TM) i7-1065G7 CPU @ 1.30GHz (8 Threads)
Issue description
The icons on the main toolbar are blurry.
You can compare with those from the side palette which are drawn correctly. The three-dot "more" icon is a good point of comparison.
Steps to reproduce
Create a new project and see the main editor window. Make sure you run a non-hidpi setup with 1920x1080 monitor, and OS scaling setting ideally set to 100% for instance, to avoid any default upscaling taking place which would make the issue not visible.
Minimal reproduction project (MRP)
N/A, sufficient to open an empty project in the editor
The text was updated successfully, but these errors were encountered: