Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The target field in FlutterOpenGLFramebuffer is misleading #148637

Open
hasali19 opened this issue May 19, 2024 · 1 comment
Open

The target field in FlutterOpenGLFramebuffer is misleading #148637

hasali19 opened this issue May 19, 2024 · 1 comment
Assignees
@chinmaygarde
Labels
e: embedder Users of the Embedder API engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-linux Building on or for Linux specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team

Comments

@hasali19
Copy link

hasali19 commented May 19, 2024 •
edited

The target field of FlutterOpenGLFramebuffer in the embedder API is poorly named and incorrectly documented. Looking at the code here, it is actually used to represent a format rather than target.
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team engine flutter/engine repository. See also e: labels. e: embedder Users of the Embedder API platform-linux Building on or for Linux specifically team-engine Owned by Engine team and removed in triage Presently being triaged by the triage team labels May 20, 2024
@jonahwilliams
Copy link
Member

oops

@jonahwilliams jonahwilliams added the P2 Important issues not at the top of the work list label May 20, 2024
@jonahwilliams jonahwilliams added the triaged-engine Triaged by Engine team label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chinmaygarde chinmaygarde

Labels
e: embedder Users of the Embedder API engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-linux Building on or for Linux specifically team-engine Owned by Engine team triaged-engine Triaged by Engine team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chinmaygarde @jonahwilliams @hasali19 @danagbemava-nc