Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable the "screenshot aborted" notification #3287

Open
AlexFolland opened this issue Aug 1, 2023 · 7 comments · May be fixed by #3610
Open

Option to disable the "screenshot aborted" notification #3287

AlexFolland opened this issue Aug 1, 2023 · 7 comments · May be fixed by #3610
Labels
Enhancement Feature requests and code enhancements Hacktoberfest
Milestone

Comments

@AlexFolland
Copy link

Feature Description

Here is my rationale for this feature request.

  • Since the Flameshot overlay disappears when I abort a screenshot, I know when the screenshot was aborted, so the notification is not useful for me to see.
  • While the notification is on-screen and I decide to start a new screenshot, the notification can be included in the screenshot, which I'd like to avoid.
  • I find the other notifications from Flameshot useful, so I do not wish to disable all Flameshot notifications; only the "screenshot aborted" notification.

Together, these cause me to wish the "screenshot aborted" notification specifically was either removed or had an option to disable it.

If there is an option to disable it, I suggest disabling the "screenshot aborted" notification by default, since it seems unlikely to me that someone might need to see such a notification.

For context, this is the notification to which I'm referring.

image

@AlexFolland AlexFolland added the Enhancement Feature requests and code enhancements label Aug 1, 2023
@mmahmoudian
Copy link
Member

Thanks for the suggestion. I myself also find it a little bit annoying but it disappears fast enough that I never thought of it as an issue. I personally completely agree with making it configurable.

At the moment user can completely turn off all notifications (even the very useful ones):
image

If there is an option to disable it, I suggest disabling the "screenshot aborted" notification by default, since it seems unlikely to me that someone might need to see such a notification.

Well, this is the part that I disagree for tow reasons:

  1. the notification can help the new user to understand the dynamic of the tool. This is extra important when something cancels Flameshot automatically.
  2. disabling it by default also means that the current default behavior of Flameshot would change. And we all know how certain people react when something visual changes.

I think it should be Enabled by default, at least for the next few versions, and then we can ask the community how they feel about it. This way the backlash would be minimal.

@mmahmoudian mmahmoudian added this to the v13 milestone Aug 3, 2023
@AlexFolland
Copy link
Author

AlexFolland commented Aug 3, 2023

My use case for aborting a screenshot is usually that the moment I see in the still frame is not the moment desired, and I'd like to quickly abort and capture the right moment instead, without having to await the disappearance of a notification. I can imagine anyone using Flameshot to capture screenshots from a game, or in my case yesterday, a graph in a performance monitoring tool, would prefer to avoid this particular waiting process.

That being said, as long as there is an option, its default value doesn't matter and it works well for my use case.

I just think that if user adoption is a priority, it is more likely for most users to want it disabled by default, especially since a large portion of users who might want to install Flameshot are likely to be gamers. I don't feel too strongly about this though.

Thank you for accepting the feature request, and your plan to ask the community is a level-headed approach.

@AlexP11223
Copy link
Contributor

How do you abort? I have never seen it.

@AlexFolland
Copy link
Author

How do you abort? I have never seen it.

This is how:
image

@AlexP11223
Copy link
Contributor

hm, I tried Esc, no notification. Other notifications appear fine, e.g. after saving.

KDE, Arch Linux.

@AlexFolland
Copy link
Author

AlexFolland commented Oct 22, 2023

OK well, I just tried it and there was a notification with the latest Flameshot built from git commit 0bbb952, which is the latest as of writing this comment. You have encountered a bug in your DE which is not caused by this feature request. I also inspected the options and found no option to disable this abort notification, and I can currently still see the notification as usual.
image

I guess your DE's notifications are bugged somehow or someone else implemented this feature request externally in KDE.

@mmahmoudian
Copy link
Member

mmahmoudian commented Oct 23, 2023

@AlexP11223 there should be a notification but it is possible that:

  1. You have turn off notifications in Flameshot
  2. In KDE Plasma you have somehow muted notifications (all together or only from Flameshot)

Try removing you Flameshot config (or rename it)

@j4k0xb j4k0xb linked a pull request May 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants