-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: list of wallets filters saved in URL #12646
Comments
@konopkja I would like to take a crack at this one as well! |
Thank you so much! Assigned you the task. |
@konopkja This will likely result in lengthy URLs for this page. Did you want current filters to be always visible in the URL (in sync to the page)? Or do you just want the option for a link to load filters once and then hide the URL data, and another option to "copy filters" which will generate the longer URL? Also a side note, we should just make sure to double check that having these query params doesn't affect any Matomo metrics by splitting data over "different pages" |
long urls are not a concern for me, do not see any issue with that matomo tracking - yes could that be prevented? @wackerow |
@bhargavkakadiya how is it going? need any assistance with this issue? |
@konopkja I can take a look into Matomo stuff... do our existing hash links (header links for example) cause any issues at the moment for you? As for the long URLs... doesn't really bother me either, but I think if we added all the "false" booleans it would likely make the URL really awkwardly long to share. As long as we just leave those off (if not present, assume false) I think it would be just fine. |
@wackerow @konopkja |
Might be worth peaking at the Simulator component ( // Track pathID
const pathId = getValidPathId(router.query.sim as string) We do something similar here where the query param is actually what is being used to track the state, instead of useState (since the query param values will stick around on page re-paints/renders, similar to useState) On an aside, put up #12842 which aims to fix any related issues with any Matomo logging and the use of query params. |
This issue is stale because it has been open 30 days with no activity. |
Is your feature request related to a problem? Please describe.
Our list of wallets offers a lot of filters to narrow down the huge list of products. Some users during user testing requested ability to send others a tailored filtered list view. This request has also appeared in user surveys further confirming potential need.
Currently we do not save switched on filters in URL.
Feature request:
Add filter parameters to URL so that the website and its users can link to a specific view of wallets. This can be used also in how to guides and other content on ethereum.org to improve UX.
Describe the solution you'd like
Describe alternatives you've considered
If too difficult, consider at least adding personas to URL
Additional context
No response
Would you like to work on this issue?
The text was updated successfully, but these errors were encountered: